native_client_sdk/src/libraries/nacl_io_test/example.dsc - Issue 16232016: [NaCl SDK] nacl_io: big refactor to return error value (errno).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/libraries/nacl_io_test/example.dsc

Issue 16232016: [NaCl SDK] nacl_io: big refactor to return error value (errno). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 # TODO(binji): pnacl doesn't build right now because gtest doesn't build yet.	2 # 'TOOLS': ['newlib', 'glibc', 'pnacl', 'win'],
noelallen1 2013/06/07 21:48:43 Isn't this comment still valid? Isn't this comment still valid? binji 2013/06/07 23:23:11 Whoops. No, pnacl works fine, I was uncommenting i Show quoted text On 2013/06/07 21:48:43, noelallen1 wrote: > Isn't this comment still valid? Whoops. No, pnacl works fine, I was uncommenting it because it was slow when I was iterating. :)
3 'TOOLS': ['newlib', 'glibc', 'pnacl', 'win'],	3 'TOOLS': ['newlib', 'glibc', 'win'],

4	4

5 # Need to add ../../examples for common.js	5 # Need to add ../../examples for common.js

6 'SEARCH': ['.', '../../examples'],	6 'SEARCH': ['.', '../../examples'],

7 'TARGETS': [	7 'TARGETS': [

8 {	8 {

9 'NAME' : 'nacl_io_test',	9 'NAME' : 'nacl_io_test',

10 'TYPE' : 'main',	10 'TYPE' : 'main',

11 'SOURCES' : [	11 'SOURCES' : [

12 'kernel_object_test.cc',	12 'kernel_object_test.cc',

13 'kernel_proxy_mock.cc',	13 'kernel_proxy_mock.cc',

(...skipping 17 matching lines...) Expand all Loading...
31 'INCLUDES': ['$(NACL_SDK_ROOT)/include/gtest/internal'],	31 'INCLUDES': ['$(NACL_SDK_ROOT)/include/gtest/internal'],

32 }	32 }

33 ],	33 ],

34 'DATA': [	34 'DATA': [

35 'example.js'	35 'example.js'

36 ],	36 ],

37 'DEST': 'tests',	37 'DEST': 'tests',

38 'NAME': 'nacl_io_test',	38 'NAME': 'nacl_io_test',

39 'TITLE': 'NaCl IO test',	39 'TITLE': 'NaCl IO test',

40 }	40 }

OLD	NEW