[NaCl SDK] nacl_io: big refactor to return error value (errno).

native_client_sdk/src/libraries/nacl_io/mount.cc

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "nacl_io/mount.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <string>
 
 #include "nacl_io/mount_node.h"
 #include "nacl_io/mount_node_dir.h"
 #include "nacl_io/mount_node_mem.h"
 #include "nacl_io/osstat.h"
 #include "nacl_io/path.h"
 #include "utils/auto_lock.h"
 #include "utils/ref_object.h"
 
 #if defined(WIN32)
 #include <windows.h>
 #endif
 
-Mount::Mount()
-  : dev_(0) {
-}
+Mount::Mount() : dev_(0) {}
 
 Mount::~Mount() {}
 
-bool Mount::Init(int dev, StringMap_t& args, PepperInterface* ppapi) {
+Error Mount::Init(int dev, StringMap_t& args, PepperInterface* ppapi) {
   dev_ = dev;
   ppapi_ = ppapi;
-  return true;
+  return 0;
 }
 
 void Mount::Destroy() {}
 
 void Mount::AcquireNode(MountNode* node) {
   AutoLock lock(&lock_);
   node->Acquire();
 }
 
 void Mount::ReleaseNode(MountNode* node) {
   AutoLock lock(&lock_);
   node->Release();
 }
 
+Error Mount::OpenResource(const Path& path, MountNode** out_node) {
+  *out_node = NULL;
+  return EINVAL;
+}
+
 int Mount::OpenModeToPermission(int mode) {
   int out;
   switch (mode & 3) {
-    case O_RDONLY: out = S_IREAD;
-    case O_WRONLY: out = S_IWRITE;
-    case O_RDWR: out = S_IREAD | S_IWRITE;
+    case O_RDONLY:

[noelallen1, 2013/06/07 21:48:43]

out = S_IREAD; break;
Doesn't match single line kernel_handle.cc switch case.

[binji, 2013/06/07 23:23:11]

Ran clang-format on this and it did this. I just ran it on kernel_handle.cc and
it did it there too.

Do you prefer it single line? I'd rather not have to fix it after a
clang-format, personally.

+      out = S_IREAD;
+    case O_WRONLY:
+      out = S_IWRITE;
+    case O_RDWR:
+      out = S_IREAD | S_IWRITE;
   }
   return out;
 }
 
-
 void Mount::OnNodeCreated(MountNode* node) {
   node->stat_.st_ino = inode_pool_.Acquire();
   node->stat_.st_dev = dev_;
 }
 
 void Mount::OnNodeDestroyed(MountNode* node) {
-  if (node->stat_.st_ino) inode_pool_.Release(node->stat_.st_ino);
-}
+  if (node->stat_.st_ino)
+    inode_pool_.Release(node->stat_.st_ino);
+}