[NaCl SDK] nacl_io: big refactor to return error value (errno).

native_client_sdk/src/libraries/nacl_io/kernel_object.h

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef LIBRARIES_NACL_IO_KERNEL_OBJECT_H_
 #define LIBRARIES_NACL_IO_KERNEL_OBJECT_H_
 
 #include <pthread.h>
 
 #include <map>
@@ skipping 11 matching lines @@
 // path resolution.
 class KernelObject {
  public:
   typedef std::vector<KernelHandle*> HandleMap_t;
   typedef std::map<std::string, Mount*> MountMap_t;
 
   KernelObject();
   virtual ~KernelObject();
 
   // Find the mount for the given path, and acquires it
-  Mount* AcquireMountAndPath(const std::string& relpath, Path *pobj);
+  int AcquireMountAndPath(const std::string& relpath,

[noelallen1, 2013/06/07 21:48:43]

Error?

[binji, 2013/06/07 23:23:11]

Done.

+                          Mount** mount,
+                          Path* pobj);
   void ReleaseMount(Mount* mnt);
 
   // Convert from FD to KernelHandle, and acquire the handle.
-  KernelHandle* AcquireHandle(int fd);
+  int AcquireHandle(int fd, KernelHandle** handle);

[noelallen1, 2013/06/07 21:48:43]

Error?

[binji, 2013/06/07 23:23:11]

Done.

   void ReleaseHandle(KernelHandle* handle);
 
   // Allocate a new fd and assign the handle to it, while
   // ref counting the handle and associated mount.
   int AllocateFD(KernelHandle* handle);
   void FreeAndReassignFD(int fd, KernelHandle* handle);
   void FreeFD(int fd);
 
  protected:
   Path GetAbsPathLocked(const std::string& path);
 
   std::vector<int> free_fds_;
   std::string cwd_;
 
   HandleMap_t handle_map_;
   MountMap_t mounts_;
 
   // Kernel lock protects kernel wide resources such as the mount table...
   pthread_mutex_t kernel_lock_;
 
   // Process lock protects process wide resources such as CWD, file handles...
   pthread_mutex_t process_lock_;
 
   DISALLOW_COPY_AND_ASSIGN(KernelObject);
 };
 
 #endif  // LIBRARIES_NACL_IO_KERNEL_OBJECT_H_