native_client_sdk/src/libraries/nacl_io/error.h - Issue 16232016: [NaCl SDK] nacl_io: big refactor to return error value (errno).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/libraries/nacl_io/error.h

Issue 16232016: [NaCl SDK] nacl_io: big refactor to return error value (errno). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 /* Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file.

	4 */

	5 #ifndef LIBRARIES_NACL_IO_ERROR_H_

	6 #define LIBRARIES_NACL_IO_ERROR_H_

	7

	8 // HACK(binji)
	Sam Clegg 2013/05/31 18:40:29 This whole file is a hack? Why? This whole file is a hack? Why? binji 2013/06/03 17:16:46 Sorry, didn't remove this yet. I was planning on h Show quoted text On 2013/05/31 18:40:29, Sam Clegg wrote: > This whole file is a hack? Why? Sorry, didn't remove this yet. I was planning on having Error be a typedef for int, instead of its own struct. The reason for having a struct here is to have the compiler catch errors -- though maybe it is worthwhile to keep (with a #define?)
	9 struct Error {

	10 Error(int error) : error(error) {}
	noelallen1 2013/06/07 21:48:43 #ifdef DEBUG Error(int errno, const char file, #ifdef DEBUG Error(int errno, const char file, int line) #define Error(x) Error(x, __FILE__, __LINE__) #endif We could actually develop an error class that on debug versions could provide us useful information. This info could get logged to buffer and then periodically scraped by the pepper thread, or even just available to via dubugging. since we can't guaranty that we can safely printf due to reentrency/locking. binji 2013/06/07 23:23:11 Added TODO Show quoted text On 2013/06/07 21:48:43, noelallen1 wrote: > #ifdef DEBUG > Error(int errno, const char *file, int line) > #define Error(x) Error(x, __FILE__, __LINE__) > #endif > > We could actually develop an error class that on debug versions could provide us > useful information. This info could get logged to buffer and then periodically > scraped by the pepper thread, or even just available to via dubugging. > since we can't guaranty that we can safely printf due to reentrency/locking. Added TODO
	11 operator int() const { return error; }

	12

	13 int error;

	14 };

	15

	16 #endif // LIBRARIES_NACL_IO_ERROR_H_

OLD	NEW

« no previous file with comments | « no previous file | native_client_sdk/src/libraries/nacl_io/kernel_handle.h » ('j') | native_client_sdk/src/libraries/nacl_io/kernel_handle.cc » ('J')