Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1753)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.h

Issue 16232004: Adds DataChannelInit param to createDataChannel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.h
diff --git a/content/renderer/media/rtc_peer_connection_handler.h b/content/renderer/media/rtc_peer_connection_handler.h
index 7fc9288188b1831e90f356c9ec2577cb5817d092..c2bf1b32eddbb7290757f0b65df6bfdad12ee258 100644
--- a/content/renderer/media/rtc_peer_connection_handler.h
+++ b/content/renderer/media/rtc_peer_connection_handler.h
@@ -128,6 +128,9 @@ class CONTENT_EXPORT RTCPeerConnectionHandler
const WebKit::WebRTCStatsRequest& request) OVERRIDE;
virtual WebKit::WebRTCDataChannelHandler* createDataChannel(
const WebKit::WebString& label, bool reliable) OVERRIDE;
+ virtual WebKit::WebRTCDataChannelHandler* createDataChannel(
+ const WebKit::WebString& label,
+ const WebKit::WebRTCDataChannelInit& init) OVERRIDE;
Ami GONE FROM CHROMIUM 2013/06/03 18:27:31 FYI if you remove OVERRIDE you can land CLs a bit
jiayl 2013/06/03 18:52:58 Hmm, but I still depend on the definition of DataC
Ami GONE FROM CHROMIUM 2013/06/03 19:32:19 True; this would just allow you to remove the old
jiayl 2013/06/03 19:54:51 I see. Makes sense! On 2013/06/03 19:32:19, Ami Fi
virtual WebKit::WebRTCDTMFSenderHandler* createDTMFSender(
const WebKit::WebMediaStreamTrack& track) OVERRIDE;
virtual void stop() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698