Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 16232002: update to ninja with path case fixes (Closed)

Created:
7 years, 6 months ago by scottmg
Modified:
7 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Update to ninja with path case fixes This is ninja at 4df15104d532ad91b7a9d3c54985180a6c2f2533. Changes since 1.3.3 include that affect this Windows build: - fixing '-t msvc' to stop lowercasing paths from /showIncludes output - fix a crash in tool target suggestions - error checking on -j. This version is newer than 1.3.3 but --version will say 1.3.0git. Other platforms are staying at 1.3.3. All platforms will re-converge at 1.4.0. R=thakis@chromium.org BUG=242397 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
M ninja.exe View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
scottmg
7 years, 6 months ago (2013-05-30 16:06:07 UTC) #1
Nico
lgtm
7 years, 6 months ago (2013-05-30 16:28:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/16232002/1
7 years, 6 months ago (2013-05-30 16:29:31 UTC) #3
commit-bot: I haz the power
Presubmit check for 16232002-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 6 months ago (2013-05-30 16:31:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/16232002/1
7 years, 6 months ago (2013-05-30 16:31:52 UTC) #5
Nico
On 2013/05/30 16:31:11, I haz the power (commit-bot) wrote: > Presubmit check for 16232002-1 failed ...
7 years, 6 months ago (2013-05-30 16:32:17 UTC) #6
Nico
On 2013/05/30 16:32:17, Nico wrote: > On 2013/05/30 16:31:11, I haz the power (commit-bot) wrote: ...
7 years, 6 months ago (2013-05-30 16:33:48 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 6 months ago (2013-05-30 16:35:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/16232002/1
7 years, 6 months ago (2013-05-30 16:35:58 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 6 months ago (2013-05-30 17:00:57 UTC) #10
scottmg
7 years, 6 months ago (2013-05-30 17:01:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r203165.

Powered by Google App Engine
This is Rietveld 408576698