Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1622913002: aw: Fix setting background color (Closed)

Created:
4 years, 11 months ago by boliu
Modified:
4 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Fix setting background color Follow up to r369480. Use the main frame routing number for setting background color IPC. BUG=580765 Committed: https://crrev.com/0deb9bea5d027018c61720d3687a31f620ce1db9 Cr-Commit-Position: refs/heads/master@{#371332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M android_webview/browser/renderer_host/aw_render_view_host_ext.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
boliu
ptal
4 years, 11 months ago (2016-01-23 19:09:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622913002/1
4 years, 11 months ago (2016-01-23 19:09:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-23 23:18:22 UTC) #6
boliu
+paulmiller for stamp
4 years, 10 months ago (2016-01-25 20:48:45 UTC) #8
hush (inactive)
lgtm
4 years, 10 months ago (2016-01-25 21:35:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622913002/1
4 years, 10 months ago (2016-01-25 21:39:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-25 22:13:14 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-25 22:14:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0deb9bea5d027018c61720d3687a31f620ce1db9
Cr-Commit-Position: refs/heads/master@{#371332}

Powered by Google App Engine
This is Rietveld 408576698