Move towards event-driven JS on about:sync

chrome/browser/resources/sync_internals/about.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 function highlightIfChanged(node, oldVal, newVal) {
   function clearHighlight() {
     this.removeAttribute('highlighted');
   }
 
   var oldStr = oldVal.toString();
   var newStr = newVal.toString();
   if (oldStr != '' && oldStr != newStr) {
     // Note the addListener function does not end up creating duplicate
     // listeners.  There can be only one listener per event at a time.
     // Reference: https://developer.mozilla.org/en/DOM/element.addEventListener
     node.addEventListener('webkitAnimationEnd', clearHighlight, false);
     node.setAttribute('highlighted', '');
   }
 }
 
 (function() {
 // Contains the latest snapshot of sync about info.
 chrome.sync.aboutInfo = {};
 
-// TODO(akalin): Make aboutInfo have key names likeThis and not
-// like_this.
 function refreshAboutInfo(aboutInfo) {
   chrome.sync.aboutInfo = aboutInfo;
   var aboutInfoDiv = $('aboutInfo');
   jstProcess(new JsEvalContext(aboutInfo), aboutInfoDiv);
 }
 
+function onAboutInfoUpdatedEvent(e) {
+  var aboutInfo = e.details;
+  refreshAboutInfo(aboutInfo);

[Dan Beam, 2014/02/13 22:32:45]

nit: refreshAboutInfo(e.details);

[rlarocque, 2014/02/13 23:34:30]

Done.

+}
+
 function onLoad() {
   $('status-data').hidden = true;
-  chrome.sync.getAboutInfo(refreshAboutInfo);
 
   chrome.sync.events.addEventListener(
-      'onServiceStateChanged',
-      function(e) {
-        chrome.sync.getAboutInfo(refreshAboutInfo);
-      });
+      'onAboutInfoUpdated',
+      onAboutInfoUpdatedEvent);
+  chrome.sync.requestUpdatedAboutInfo();
 
   var dumpStatusButton = $('dump-status');
   dumpStatusButton.addEventListener('click', function(event) {
     var aboutInfo = chrome.sync.aboutInfo;
     if (!$('include-ids').checked) {
       aboutInfo.details = chrome.sync.aboutInfo.details.filter(function(el) {
         return !el.is_sensitive;
       });
     }
     var data = '';
@@ skipping 19 matching lines @@
     var data = $('status-text').value;
     var firstBrace = data.indexOf('{');
     if (firstBrace < 0) {
       $('status-text').value = 'Invalid sync status dump.';
       return;
     }
     data = data.substr(firstBrace);
 
     // Remove listeners to prevent sync events from overwriting imported data.
     chrome.sync.events.removeEventListener(
-        'onServiceStateChanged',
-        refreshAboutInfo);
+        'onAboutInfoUpdated',
+        onAboutInfoUpdatedEvent);
 
     var aboutInfo = JSON.parse(data);
     refreshAboutInfo(aboutInfo);
   });
 }
 
 document.addEventListener('DOMContentLoaded', onLoad, false);
 })();