appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py - Issue 1622813003: [Findit] Adding support for extracting revisions from dict instead of list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

Issue 1622813003: [Findit] Adding support for extracting revisions from dict instead of list (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressing code review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py ('k') | appengine/findit/waterfall/test/try_job_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

index ef0fc831659e9e4931eefaf9d3c806b61bcbc242..e432c910ed5af58029bea022ae7bd3f4ad6fe69a 100644

--- a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

+++ b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

@@ -9,7 +9,9 @@ from model import wf_analysis_status

from model.wf_try_job import WfTryJob

from waterfall.monitor_try_job_pipeline import MonitorTryJobPipeline

class MonitorTryJobPipelineTest(testing.AppengineTestCase):

def _Mock_GetTryJobs(self, build_id):

def Mocked_GetTryJobs(*_):

data = {

@@ -50,7 +52,7 @@ class MonitorTryJobPipelineTest(testing.AppengineTestCase):

try_job = WfTryJob.Create(master_name, builder_name, build_number)

try_job.compile_results = [

{

- 'result': None,

+ 'report': None,

'url': 'url',

'try_job_id': '1',

}

@@ -64,7 +66,7 @@ class MonitorTryJobPipelineTest(testing.AppengineTestCase):

master_name, builder_name, build_number, try_job_id)

expected_compile_result = {

- 'result': [

+ 'report': [

['rev1', 'passed'],

['rev2', 'failed']