appengine/findit/waterfall/monitor_try_job_pipeline.py - Issue 1622813003: [Findit] Adding support for extracting revisions from dict instead of list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/monitor_try_job_pipeline.py

Issue 1622813003: [Findit] Adding support for extracting revisions from dict instead of list (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressing code review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/identify_try_job_culprit_pipeline.py ('k') | appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/monitor_try_job_pipeline.py

diff --git a/appengine/findit/waterfall/monitor_try_job_pipeline.py b/appengine/findit/waterfall/monitor_try_job_pipeline.py

index af4e4558df1f8bbe20565cda6f938a62889e5e91..e96e67e57915c5460b690edfb7089331d3bbcd7f 100644

--- a/appengine/findit/waterfall/monitor_try_job_pipeline.py

+++ b/appengine/findit/waterfall/monitor_try_job_pipeline.py

@@ -34,7 +34,7 @@ class MonitorTryJobPipeline(BasePipeline):

'Error "%s" occurred. Reason: "%s"' % (error.message, error.reason))

elif build.status == 'COMPLETED':

result = {

- 'result': build.result,

+ 'report': build.report,

'url': build.url,

'try_job_id': try_job_id,

}

@@ -51,7 +51,7 @@ class MonitorTryJobPipeline(BasePipeline):

else: # pragma: no cover

if build.status == 'STARTED' and not already_set_started:

result = {

- 'result': None,

+ 'report': None,

'url': build.url,

'try_job_id': try_job_id,

}