[Findit] Adding support for extracting revisions from dict instead of list

appengine/findit/waterfall/monitor_try_job_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import time
 
 from common import buildbucket_client
 from model import wf_analysis_status
 from model.wf_try_job import WfTryJob
 from pipeline_wrapper import BasePipeline
@@ skipping 16 matching lines @@
     deadline = time.time() + timeout_hours * 60 * 60
 
     already_set_started = False
     while True:
       error, build = buildbucket_client.GetTryJobs([try_job_id])[0]
       if error:  # pragma: no cover
         raise pipeline.Retry(
             'Error "%s" occurred. Reason: "%s"' % (error.message, error.reason))
       elif build.status == 'COMPLETED':
         result = {
-            'result': build.result,
+            'report': build.report,
             'url': build.url,
             'try_job_id': try_job_id,
         }
 
         try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
         if (try_job_result.compile_results and
             try_job_result.compile_results[-1]['try_job_id'] == try_job_id):
           try_job_result.compile_results[-1].update(result)
         else:  # pragma: no cover
           try_job_result.compile_results.append(result)
 
         try_job_result.put()
         return try_job_result.compile_results[-1]

[stgao, 2016/01/27 01:24:21]

Return build.report directly if the other fields are not used in other pipeline?

[lijeffrey, 2016/01/28 02:14:35]

It turns out IdentifyTryJobCulpritPipeline still needs the full compile_result
dict when it finds a culprit so it can update it with compile_result['culprit']
= culprit.

https://code.google.com/p/chromium/issues/detail?id=581933

Should address refactoring this out in a separate CL.

       else:  # pragma: no cover
         if build.status == 'STARTED' and not already_set_started:
           result = {
-              'result': None,
+              'report': None,
               'url': build.url,
               'try_job_id': try_job_id,
           }
 
           try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
           if (try_job_result.compile_results and
               try_job_result.compile_results[-1]['try_job_id'] == try_job_id):
             try_job_result.compile_results[-1].update(result)
           else:  # pragma: no cover
             # Normally result for current try job should've been saved in
             # schedule_try_job_pipeline, so this branch shouldn't be reached.
             try_job_result.compile_results.append(result)
 
           try_job_result.status = wf_analysis_status.ANALYZING
           try_job_result.put()
           already_set_started = True
 
         time.sleep(60)
 
       if time.time() > deadline:  # pragma: no cover
         try_job_result.status = wf_analysis_status.ERROR
         try_job_result.put()
         # Explicitly abort the whole pipeline.
         raise pipeline.Abort(
             'Try job %s timed out after %d hours.' % (
                 try_job_id, timeout_hours))