Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1622793006: X87: [stubs] Introduce ToNameStub to implement %_ToName. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Introduce ToNameStub to implement %_ToName. port a0878333de4dd090f9d8987e1698a9eef9cc7219(r33460) original commit message: We already had hand-written optimized code for %_ToName in fullcodegen, but the optimizing compilers always went to the runtime for %_ToName, which is pretty bad for many of our builtins. So this CL moves the existing native code to a ToNameStub (similar to the existing ToStringStub), and uses the ToNameStub consistently in all compilers to actually implement %_ToName. BUG= Committed: https://crrev.com/f55b66ca387edced547e55fb00f99be8e47d1be5 Cr-Commit-Position: refs/heads/master@{#33483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-25 06:35:22 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-25 07:15:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622793006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622793006/1
4 years, 11 months ago (2016-01-25 07:19:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 07:39:50 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 07:40:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f55b66ca387edced547e55fb00f99be8e47d1be5
Cr-Commit-Position: refs/heads/master@{#33483}

Powered by Google App Engine
This is Rietveld 408576698