ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java - Issue 1622773002: Fix date picker performance issues, crash, and incorrect pre-1582 dates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java

Issue 1622773002: Fix date picker performance issues, crash, and incorrect pre-1582 dates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/android/java/src/org/chromium/ui/picker/DateDialogNormalizer.java ('k') | ui/android/java/src/org/chromium/ui/picker/InputDialogContainer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java

diff --git a/ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java b/ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java

index cd1b8846dd4c6e012c0ea10c26c15eefae1368b5..77a100afedf2233896233d631c84e2bdb65ba92c 100644

--- a/ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java

+++ b/ui/android/java/src/org/chromium/ui/picker/DateTimePickerDialog.java

@@ -88,7 +88,7 @@ public class DateTimePickerDialog extends AlertDialog implements OnClickListener

setView(view);

mDatePicker = (DatePicker) view.findViewById(R.id.date_picker);

DateDialogNormalizer.normalize(mDatePicker, this,

- year, monthOfYear, dayOfMonth, hourOfDay, minute, mMinTimeMillis, mMaxTimeMillis);

+ year, monthOfYear, dayOfMonth, mMinTimeMillis, mMaxTimeMillis);

mTimePicker = (TimePicker) view.findViewById(R.id.time_picker);

mTimePicker.setIs24HourView(is24HourView);