Convert Google Now's Authentication Manager to use Promises

chrome/browser/resources/google_now/common_test_util.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Common test utilities.
 
 /**
  * Allows console.log output.
  */
 var showConsoleLogOutput = false;
@@ skipping 64 matching lines @@
 /**
  * MockPromise
  * The JS test harness expects all calls to complete synchronously.
  * As a result, we can't use built-in JS promises since they run asynchronously.
  * Instead of mocking all possible calls to promises, a skeleton
  * implementation is provided to get the tests to pass.
  */
 var Promise = function() {
   function PromisePrototypeObject(asyncTask) {
     var result;
+    var resolved = false;
     asyncTask(
         function(asyncResult) {
           result = asyncResult;
+          resolved = true;
         },
-        function() {}); // Errors are unsupported.
+        function(asyncFailureResult) {
+          result = asyncResult;

[rgustafson, 2014/02/14 02:12:07]

asyncFailureResult?

[robliao, 2014/02/14 02:28:25]

Done.

+          resolved = false;
+        });
 
     function then(callback) {
-      callback.call(null, result);
+      if (resolved) {
+        callback.call(null, result);
+      }
+      return this;
     }
-    return {then: then, isPromise: true};
+
+    // Promises use the function name "catch" to call back error handlers.
+    // We can't use "catch" since function or variable names cannot use the word
+    // "catch".
+    function catchFunc(callback) {
+      if (!resolved) {
+        callback.call(null, result);
+      }
+      return this;
+    }
+
+    return {then: then, catch: catchFunc, isPromise: true};
   }
 
   function all(arrayOfPromises) {
     var results = [];
     for (i = 0; i < arrayOfPromises.length; i++) {
       if (arrayOfPromises[i].isPromise) {
         arrayOfPromises[i].then(function(result) {
           results[i] = result;
         });
       } else {
         results[i] = arrayOfPromises[i];
       }
     }
     var promise = new PromisePrototypeObject(function(resolve) {
       resolve(results);
     });
     return promise;
   }
   PromisePrototypeObject.all = all;
   return PromisePrototypeObject;
 }();