Add a count of total lines to status performance page

Add a count of total lines to status performance page

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/1ecd06d39cbfa120709f1d986c25761e17f68e53

[Brian Wilkerson, 2016-01-22 21:03:36]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-01-22 21:03:36]

It's amazingly slow to count the lines. I'm wondering whether I should use
`getLineCounts` instead of `computeLineCounts` (or just not commit this). Ideas
welcome.

[scheglov, 2016-01-22 21:29:08]

LGTM

Yes, if computing LINE_INFO takes long and can potentially skew the performance
statistics, it is better to use getLineInfo() instead.
Maybe also show whether the line statistics is complete or some sources don't
have LINE_INFO computed yet.

> It's amazingly slow to count the lines. I'm wondering whether I should use
> `getLineCounts` instead of `computeLineCounts` (or just not commit this).
Ideas
> welcome.

[Brian Wilkerson, 2016-01-22 22:25:09]

PTAL, I fixed a bug that caused some sources to be counted multiple times, which
accounted for the speed issue.

[scheglov, 2016-01-22 22:26:40]

LGTM

[Brian Wilkerson, 2016-01-22 22:37:32]

Description was changed from

==========
Add a count of total lines to status performance page
==========

to

==========
Add a count of total lines to status performance page

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1ecd06d39cbfa120709f1d986c25761e17f68e53
==========

[Brian Wilkerson, 2016-01-22 22:37:36]

Committed patchset #2 (id:20001) manually as
1ecd06d39cbfa120709f1d986c25761e17f68e53 (presubmit successful).

[Paul Berry, 2016-01-23 13:34:34]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2016-01-23 13:34:35]

Technically this is a breaking change to the analyzer because it adds a new
method to a class which is implemented by a client library.  This is causing a
breakage in the analyzer buildbot (see
https://build.chromium.org/p/client.dart/builders/analyzer_experimental-linux...)

[Paul Berry, 2016-01-23 14:10:43]

On 2016/01/23 13:34:35, Paul Berry wrote:
> Technically this is a breaking change to the analyzer because it adds a new
> method to a class which is implemented by a client library.  This is causing a
> breakage in the analyzer buildbot (see
>
https://build.chromium.org/p/client.dart/builders/analyzer_experimental-linux...)

Proposed fix: https://codereview.chromium.org/1625783002/