[Autofill] Re-introduce some debug logs for Autofill queries.

[Autofill] Re-introduce some debug logs for Autofill queries.

We lost debug output when moving from XML to Proto, now adding it again.

BUG=None
TEST=Manual

Committed: https://crrev.com/06bcd96e1f26b73a59050d384d505e05c278161c
Cr-Commit-Position: refs/heads/master@{#371093}

[Mathieu, 2016-01-22 20:29:05]

Description was changed from

==========
[Autofill] Re-introduce some debug logs for Autofill queries.

We lost debug output when moving from XML to Proto, now adding it again.

BUG=None
TEST=Manual
==========

to

==========
[Autofill] Re-introduce some debug logs for Autofill queries.

We lost debug output when moving from XML to Proto, now adding it again.

BUG=None
TEST=Manual
==========

[Mathieu, 2016-01-22 20:29:05]

mathp@chromium.org changed reviewers:
+ rogerm@chromium.org

[Mathieu, 2016-01-22 21:07:22]

Hi Roger, please have a look!

[Roger McFarlane (Chromium), 2016-01-22 21:52:30]

Thinking aloud:
I think people generally try to stay line oriented when logging. Maybe convert
the output to a single formatted line? Not sure it's worth the trouble for VLOG,
though.

https://codereview.chromium.org/1622703002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_download_manager.cc (right):

https://codereview.chromium.org/1622703002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_download_manager.cc:94: std::ostream&
operator<<(std::ostream& s,
maybe rename s to out or stream

https://codereview.chromium.org/1622703002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_download_manager.cc:101: << "\n 
signature: " << field.signature();
nit: will this fit merged with the previous line?

https://codereview.chromium.org/1622703002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_download_manager.cc:129: << "\n
autofill_type: " << field.autofill_type();
this is a number or a string?

FieldType_Name(field.autofill_type()) ?

[Mathieu, 2016-01-22 22:15:12]

Thanks. I think for VLOG it's ok. you have to explicitely specify
--vmodule=*autofill*=1,*form*=1 to get this, so at this point you deserve nice
formatting.

https://codereview.chromium.org/1622703002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_download_manager.cc (right):

https://codereview.chromium.org/1622703002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_download_manager.cc:94: std::ostream&
operator<<(std::ostream& s,
On 2016/01/22 21:52:30, Roger McFarlane (Chromium) wrote:
> maybe rename s to out or stream

Done.

https://codereview.chromium.org/1622703002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_download_manager.cc:101: << "\n 
signature: " << field.signature();
On 2016/01/22 21:52:30, Roger McFarlane (Chromium) wrote:
> nit: will this fit merged with the previous line?

Done.

https://codereview.chromium.org/1622703002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_download_manager.cc:129: << "\n
autofill_type: " << field.autofill_type();
On 2016/01/22 21:52:30, Roger McFarlane (Chromium) wrote:
> this is a number or a string?
> 
> FieldType_Name(field.autofill_type()) ?

Unfortunately it's not a proto in Chromium, it's a number

[Mathieu, 2016-01-22 22:18:31]

mathp@chromium.org changed reviewers:
+ fserb@chromium.org

[fserb, 2016-01-22 22:27:17]

lgtm

[Mathieu, 2016-01-22 22:51:14]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-01-22 22:51:14]

The patchset sent to the CQ was uploaded after l-g-t-m from fserb@chromium.org
Link to the patchset: https://codereview.chromium.org/1622703002/#ps40001
(title: "clean")

[commit-bot: I haz the power, 2016-01-22 22:53:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1622703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1622703002/40001

[commit-bot: I haz the power, 2016-01-23 00:08:20]

Description was changed from

==========
[Autofill] Re-introduce some debug logs for Autofill queries.

We lost debug output when moving from XML to Proto, now adding it again.

BUG=None
TEST=Manual
==========

to

==========
[Autofill] Re-introduce some debug logs for Autofill queries.

We lost debug output when moving from XML to Proto, now adding it again.

BUG=None
TEST=Manual
==========

[commit-bot: I haz the power, 2016-01-23 00:08:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-23 00:10:25]

Description was changed from

==========
[Autofill] Re-introduce some debug logs for Autofill queries.

We lost debug output when moving from XML to Proto, now adding it again.

BUG=None
TEST=Manual
==========

to

==========
[Autofill] Re-introduce some debug logs for Autofill queries.

We lost debug output when moving from XML to Proto, now adding it again.

BUG=None
TEST=Manual

Committed: https://crrev.com/06bcd96e1f26b73a59050d384d505e05c278161c
Cr-Commit-Position: refs/heads/master@{#371093}
==========

[commit-bot: I haz the power, 2016-01-23 00:10:26]

Patchset 3 (id:??) landed as
https://crrev.com/06bcd96e1f26b73a59050d384d505e05c278161c
Cr-Commit-Position: refs/heads/master@{#371093}