Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: pkg/analyzer/tool/summary/idl.dart

Issue 1622673002: Drop implicit types from summaries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/tool/summary/idl.dart
diff --git a/pkg/analyzer/tool/summary/idl.dart b/pkg/analyzer/tool/summary/idl.dart
index 25b3951de43480ce2b8258a0fd4aad76f0914d9f..588c3b3d3fd2a0e93e4f230e17af17b7f347eb5f 100644
--- a/pkg/analyzer/tool/summary/idl.dart
+++ b/pkg/analyzer/tool/summary/idl.dart
@@ -587,10 +587,25 @@ enum UnlinkedConstOperation {
/**
* Pop the top n values from the stack (where n is obtained from
* [UnlinkedConst.ints]), place them in a [List], and push the result back
+ * onto the stack. The type parameter for the [List] is implicitly `dynamic`.
+ */
+ makeUntypedList,
+
+ /**
+ * Pop the top 2*n values from the stack (where n is obtained from
+ * [UnlinkedConst.ints]), interpret them as key/value pairs, place them in a
+ * [Map], and push the result back onto the stack. The two type parameters
+ * for the [Map] are implicitly `dynamic`.
+ */
+ makeUntypedMap,
+
+ /**
+ * Pop the top n values from the stack (where n is obtained from
+ * [UnlinkedConst.ints]), place them in a [List], and push the result back
* onto the stack. The type parameter for the [List] is obtained from
* [UnlinkedConst.references].
*/
- makeList,
+ makeTypedList,
/**
* Pop the top 2*n values from the stack (where n is obtained from
@@ -598,7 +613,7 @@ enum UnlinkedConstOperation {
* [Map], and push the result back onto the stack. The two type parameters for
* the [Map] are obtained from [UnlinkedConst.references].
*/
- makeMap,
+ makeTypedMap,
/**
* Pop the top 2 values from the stack, pass them to the predefined Dart
@@ -859,8 +874,7 @@ class UnlinkedExecutable {
/**
* Declared return type of the executable. Absent if the executable is a
- * constructor. Note that when strong mode is enabled, the actual return
- * type may be different due to type inference.
+ * constructor or the return type is implicit.
*/
EntityRef returnType;
@@ -902,12 +916,6 @@ class UnlinkedExecutable {
bool isFactory;
/**
- * Indicates whether the executable lacks an explicit return type
- * declaration. False for constructors and setters.
- */
- bool hasImplicitReturnType;
-
- /**
* Indicates whether the executable is declared using the `external` keyword.
*/
bool isExternal;
@@ -1058,7 +1066,8 @@ class UnlinkedParam {
/**
* If [isFunctionTyped] is `true`, the declared return type. If
- * [isFunctionTyped] is `false`, the declared type.
+ * [isFunctionTyped] is `false`, the declared type. Absent if the type is
+ * implicit.
*/
EntityRef type;
@@ -1082,12 +1091,6 @@ class UnlinkedParam {
* declared using `this.` syntax).
*/
bool isInitializingFormal;
-
- /**
- * Indicates whether this parameter lacks an explicit type declaration.
- * Always false for a function-typed parameter.
- */
- bool hasImplicitType;
}
/**
@@ -1380,8 +1383,7 @@ class UnlinkedVariable {
UnlinkedDocumentationComment documentationComment;
/**
- * Declared type of the variable. Note that when strong mode is enabled, the
- * actual type of the variable may be different due to type inference.
+ * Declared type of the variable. Absent if the type is implicit.
*/
EntityRef type;
@@ -1411,11 +1413,6 @@ class UnlinkedVariable {
bool isConst;
/**
- * Indicates whether this variable lacks an explicit type declaration.
- */
- bool hasImplicitType;
-
- /**
* If this variable is propagable, nonzero slot id identifying which entry in
* [LinkedLibrary.types] contains the propagated type for this variable. If
* there is no matching entry in [LinkedLibrary.types], then this variable's

Powered by Google App Engine
This is Rietveld 408576698