chrome/browser/resources/settings/appearance_page/appearance_page.js - Issue 1622663002: WebUI: Replace cr.sendWithCallback with cr.sendWithPromise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 1622663002: WebUI: Replace cr.sendWithCallback with cr.sendWithPromise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments: Removing new line before anonymous function. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/appearance_page/appearance_page.js

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js

index 52691cb918f6c2e4d7f0b1bbc1f59d9e3a4721ed..37377ed17caaa31f9c2ff0de5bd1cf0fbdf2b284 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js

+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js

@@ -124,8 +124,9 @@ Polymer({

/** @override */

attached: function() {

// Query the initial state.

- cr.sendWithCallback('getResetThemeEnabled', undefined,

- this.setResetThemeEnabled.bind(this));

+ cr.sendWithPromise('getResetThemeEnabled').then(function(response) {

+ this.setResetThemeEnabled(response[0]);

+ }.bind(this));

// Set up the change event listener.

cr.addWebUIListener('reset-theme-enabled-changed',

« no previous file with comments | « no previous file | chrome/chrome_tests.gypi » ('j') | chrome/test/data/webui/webui_resource_async_browsertest.js » ('J')