WebUI: Replace cr.sendWithCallback with cr.sendWithPromise.

chrome/browser/resources/settings/appearance_page/appearance_page.js

Index: chrome/browser/resources/settings/appearance_page/appearance_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js
index 52691cb918f6c2e4d7f0b1bbc1f59d9e3a4721ed..8ad57fa8d29272cdd0d9992d35d6e2770dfaf8d4 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js
@@ -124,8 +124,10 @@ Polymer({
   /** @override */
   attached: function() {
     // Query the initial state.
-    cr.sendWithCallback('getResetThemeEnabled', undefined,
-                        this.setResetThemeEnabled.bind(this));
+    cr.sendWithPromise('getResetThemeEnabled').then(
+        function(response) {
+          this.setResetThemeEnabled(response[0]);
+        }.bind(this));

[Dan Beam, 2016/01/25 23:13:38]

cr.sendWithPromise('getResetThemeEnabled').then(function(response) {
  this.setResetThemeEnabled(response[0]);
}.bind(this));

would save a line

[dpapad, 2016/01/25 23:54:44]

Breaking line before anonymous function is fairly common. Sometimes is required,
because it allows adding @param annotations, and sometimes it is just for
readability. I don't think there is a hard rule in the styleguide about one or
the other, so can we consider this (and similar comment in
webui_resource_async_browsertest.js) an optional nit?

[Dan Beam, 2016/01/25 23:56:43]

n
o

[dpapad, 2016/01/26 00:44:53]

Done. Summarizing lengthy IM discussion: Changing this to unblock this CL.

Personally I find that readability is improved when I can visually locate the
start/end of a function faster, and that happens when \n is before "function".

On 2016/01/25 at 23:56:43, Dan Beam wrote:

 
     // Set up the change event listener.
     cr.addWebUIListener('reset-theme-enabled-changed',