Issue 16226028: Fix even more remaining uses of WeakPtr<T>'s operator T* conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16226028: Fix even more remaining uses of WeakPtr<T>'s operator T* conversion (Closed)

Created:
7 years, 6 months ago by akalin

Modified:
7 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, cbentzel+watch_chromium.org, Raghu Simha, gavinp+memory_chromium.org, apatrick_chromium, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., chromium-apps-reviews_chromium.org, haitaol1, erikwright+watch_chromium.org, tim (not reviewing), gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix even more remaining uses of WeakPtr<T>'s operator T* conversion These cases weren't caught by the automated pass and/or needed to be solved in another way than using .get(). BUG=245942 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204036

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -37 lines)			Patch
M	base/memory/weak_ptr_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_action_unittest.cc	View	3 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/glue/shared_change_processor_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/context_group.cc	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	net/http/http_cache_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_write_queue.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_ftp_job_unittest.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	net/url_request/url_request_http_job_unittest.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	sync/internal_api/public/util/weak_handle.h	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	sync/internal_api/public/util/weak_handle_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/browser/quota/quota_manager.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/16226028/1

7 years, 6 months ago (2013-06-04 19:27:09 UTC) #2

akalin

7 years, 6 months ago (2013-06-04 20:54:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r204036 (presubmit successful).

Expand Messages | Collapse Messages