Issue 16226020: MIPS: Turn off allocation site info for crankshafted array constructor calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16226020: MIPS: Turn off allocation site info for crankshafted array constructor calls. (Closed)

Created:
7 years, 6 months ago by kilvadyb

Modified:
7 years, 6 months ago

Reviewers:
kisg, Paul Lind, palfia, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Turn off allocation site info for crankshafted array constructor calls. Port r14934 (dbddd7e) Original commit message: Once we crankshaft a method, we should turn off allocation site info for constructed arrays. Additionally, the semantics for doing this were awkward because the constructed array code stubs get an AllocationSiteMode as a minor key, but it's used as a permission to determine the final mode locally based on ElementsKind. I refactored this to a simpler boolean for override or local control. BUG=

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Committed as r14943.

Expand Messages | Collapse Messages