Issue 16226011: Fix r151732.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16226011: Fix r151732. (Closed)

Created:
7 years, 6 months ago by marja

Modified:
7 years, 6 months ago

Reviewers:
dcarney, abarth-chromium

CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix r151732. BUG=236290 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151746

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -7 lines)			Patch
	M	Source/bindings/v8/ScriptProfiler.cpp	View		2 chunks	+25 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/16226011/1

7 years, 6 months ago (2013-06-04 11:46:48 UTC) #2

abarth-chromium

It would be better of the description explained a bit more about the CL. What ...

7 years, 6 months ago (2013-06-04 16:17:34 UTC) #4

marja

7 years, 6 months ago (2013-06-04 16:23:57 UTC) #5

Message was sent while issue was closed.

Ahh, sorry, too late to add it in the changelist descprtion, but here's the
explanation: r151732 did this change to V8GCCollector. It should've updated
Scriptprofiler in the same way, too.

Expand Messages | Collapse Messages