Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: slave/skia_slave_scripts/build_step.py

Issue 16226005: Run skimage on the bots. (Closed) Base URL: https://skia.googlecode.com/svn/buildbot
Patch Set: Look for expectations in trunk. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: slave/skia_slave_scripts/build_step.py
diff --git a/slave/skia_slave_scripts/build_step.py b/slave/skia_slave_scripts/build_step.py
index f65de908d103de102aaaa3b00d98159a919f6630..578bbb132b48ce15403dc9edfe8a48d8d184f267 100644
--- a/slave/skia_slave_scripts/build_step.py
+++ b/slave/skia_slave_scripts/build_step.py
@@ -84,11 +84,15 @@ class BuildStepLogger(object):
class DeviceDirs(object):
def __init__(self, perf_data_dir, gm_actual_dir, gm_expected_dir,
- resource_dir, skp_dir, skp_perf_dir, skp_out_dir, tmp_dir):
+ resource_dir, skimage_in_dir, skimage_expected_dir,
+ skimage_out_dir, skp_dir, skp_perf_dir, skp_out_dir, tmp_dir):
self._perf_data_dir = perf_data_dir
self._gm_actual_dir = gm_actual_dir
self._gm_expected_dir = gm_expected_dir
self._resource_dir = resource_dir
+ self._skimage_in_dir = skimage_in_dir
+ self._skimage_expected_dir = skimage_expected_dir
+ self._skimage_out_dir = skimage_out_dir
self._skp_dir = skp_dir
self._skp_perf_dir = skp_perf_dir
self._skp_out_dir = skp_out_dir
@@ -106,6 +110,15 @@ class DeviceDirs(object):
def ResourceDir(self):
return self._resource_dir
+ def SKImageInDir(self):
+ return self._skimage_in_dir
+
+ def SKImageExpectedDir(self):
+ return self._skimage_expected_dir
+
+ def SKImageOutDir(self):
+ return self._skimage_out_dir
+
def SKPDir(self):
return self._skp_dir
@@ -232,6 +245,13 @@ class BuildStep(multiprocessing.Process):
self._perf_data_dir = None
self._perf_graphs_dir = None
+ self._skimage_in_dir = os.path.join(os.pardir, 'skimage_in')
+
+ self._skimage_expected_dir = os.path.join('expectations', 'skimage')
borenet 2013/06/26 12:54:45 Not using gm_image_subdir, since we're using a fla
scroggo 2013/06/26 15:06:39 That is correct. We're actually using gm_image_sub
+
+ self._skimage_out_dir = os.path.join('out', self._configuration,
+ 'skimage_out')
+
# Note that DeviceDirs.GMExpectedDir() is being set up to point at a
# DIFFERENT directory than self._gm_expected.
# self._gm_expected : The SVN-managed directory on the buildbot host
@@ -249,6 +269,9 @@ class BuildStep(multiprocessing.Process):
gm_actual_dir=os.path.join(os.pardir, os.pardir, 'gm', 'actual'),
gm_expected_dir=os.path.join(os.pardir, os.pardir, 'gm', 'expected'),
resource_dir=self._resource_dir,
+ skimage_in_dir=self._skimage_in_dir,
+ skimage_expected_dir=self._skimage_expected_dir,
+ skimage_out_dir=self._skimage_out_dir,
skp_dir=self._local_playback_dirs.PlaybackSkpDir(),
skp_perf_dir=self._perf_data_dir,
skp_out_dir=self._local_playback_dirs.PlaybackGmActualDir(),

Powered by Google App Engine
This is Rietveld 408576698