Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: master/skia_master_scripts/factory.py

Issue 16226005: Run skimage on the bots. (Closed) Base URL: https://skia.googlecode.com/svn/buildbot
Patch Set: Respond to comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: master/skia_master_scripts/factory.py
diff --git a/master/skia_master_scripts/factory.py b/master/skia_master_scripts/factory.py
index 6b2853d3f7782bc30404e704764a7f0aeb7349bb..336d896910c4632d5fe201a905da762c657f8581 100644
--- a/master/skia_master_scripts/factory.py
+++ b/master/skia_master_scripts/factory.py
@@ -443,6 +443,12 @@ class SkiaFactory(BuildFactory):
self.AddSlaveScript(script='download_skps.py', description='DownloadSKPs',
halt_on_failure=True)
+ def DownloadSKImageFiles(self):
+ """ Download image files for running skimage. """
+ self.AddSlaveScript(script='download_skimage_files.py',
+ description='DownloadSKImageFiles',
+ halt_on_failure=True)
+
def DownloadBaselines(self):
""" Download the GM baselines. """
self.AddSlaveScript(script='download_baselines.py',
@@ -452,6 +458,11 @@ class SkiaFactory(BuildFactory):
""" Run the unit tests. """
self.AddFlavoredSlaveScript(script='run_tests.py', description='RunTests')
+ def RunDecodingTests(self):
+ """ Run tests of image decoders. """
+ self.AddFlavoredSlaveScript(script='run_decoding_tests.py',
+ description='RunDecodingTests')
+
def RunGM(self):
""" Run the "GM" tool, saving the images to disk. """
self.AddFlavoredSlaveScript(script='run_gm.py', description='GenerateGMs',
@@ -619,6 +630,10 @@ class SkiaFactory(BuildFactory):
description='UploadGMResults', timeout=5400,
is_rebaseline_step=True)
+ def UploadSKImageResults(self):
+ self.AddSlaveScript(script='upload_skimage_results.py',
+ description="UploadSKImageResults")
+
def CommonSteps(self, clobber=None):
""" Steps which are run at the beginning of all builds. """
self.UpdateSteps()
@@ -629,15 +644,18 @@ class SkiaFactory(BuildFactory):
def NonPerfSteps(self):
""" Add correctness testing BuildSteps. """
self.DownloadBaselines()
+ self.DownloadSKImageFiles()
self.PreRender()
self.RunTests()
self.RunGM()
self.RenderPictures()
self.RenderPdfs()
+ self.RunDecodingTests()
self.PostRender()
if self._do_upload_results:
self.UploadGMResults()
self.CompareAndUploadWebpageGMs()
+ self.UploadSKImageResults()
self.CompareGMs()
def PerfSteps(self):
« no previous file with comments | « no previous file | slave/skia_slave_scripts/android_build_step.py » ('j') | slave/skia_slave_scripts/download_skimage_files.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698