slave/skia_slave_scripts/get_subdir.py - Issue 16226005: Run skimage on the bots.

Side by Side Diff: slave/skia_slave_scripts/get_subdir.py

Issue 16226005: Run skimage on the bots. (Closed) Base URL: https://skia.googlecode.com/svn/buildbot

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« slave/skia_slave_scripts/chromeos_postrender.py ('K') | « slave/skia_slave_scripts/download_skimage_files.py ('k') | slave/skia_slave_scripts/install.py » ('j') | slave/skia_slave_scripts/update.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """ Function to get the appropriate skimage subdir from the builder name. """

	6

	7 # Expectations files are stored in a folder corresponding to the builder

	8 # name. Return the name of the folder based on the builder_name.

	9 def GetSubDirFromBuilderName(builder_name):
	scroggo 2013/06/24 17:43:16 This is a hack I've used to grab the right expecta This is a hack I've used to grab the right expectations file. borenet 2013/06/25 18:19:12 I made this comment in BuildStep - it looks like w Show quoted text On 2013/06/24 17:43:16, scroggo wrote: > This is a hack I've used to grab the right expectations file. I made this comment in BuildStep - it looks like we could just use self._gm_image_subdir instead of having this function. IMO it's better not to spread this hack around. The downside is that it's sometimes None (which is perfectly okay), so you'll have to check for that. scroggo 2013/06/25 19:28:56 Done. What is the correct way to handle None? It s Show quoted text On 2013/06/25 18:19:12, borenet wrote: > On 2013/06/24 17:43:16, scroggo wrote: > > This is a hack I've used to grab the right expectations file. > > I made this comment in BuildStep - it looks like we could just use > self._gm_image_subdir instead of having this function. IMO it's better not to > spread this hack around. The downside is that it's sometimes None (which is > perfectly okay), so you'll have to check for that. Done. What is the correct way to handle None? It seems like we could skip the test, since we won't have anything to compare against. Do we still run gm in that case?
	10 # Mapping of expectations subdir

	11 # to builder name (see list at http://108.170.217.252:10117/builders )

	12 # Copied from rebaseline.py

	13 SUBDIR_MAPPING = {

	14 'base-shuttle-win7-intel-float':

	15 'Test-Win7-ShuttleA-HD2000-x86-Release',

	16 'base-shuttle-win7-intel-angle':

	17 'Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE',

	18 'base-shuttle-win7-intel-directwrite':

	19 'Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite',

	20 'base-shuttle_ubuntu12_ati5770':

	21 'Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release',

	22 'base-macmini':

	23 'Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release',

	24 'base-macmini-lion-float':

	25 'Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release',

	26 'base-android-galaxy-nexus':

	27 'Test-Android-GalaxyNexus-SGX540-Arm7-Debug',

	28 'base-android-nexus-7':

	29 'Test-Android-Nexus7-Tegra3-Arm7-Release',

	30 'base-android-nexus-s':

	31 'Test-Android-NexusS-SGX540-Arm7-Release',

	32 'base-android-xoom':

	33 'Test-Android-Xoom-Tegra2-Arm7-Release',

	34 'base-android-nexus-10':

	35 'Test-Android-Nexus10-MaliT604-Arm7-Release',

	36 }

	37 for k, v in SUBDIR_MAPPING.items():

	38 if v == builder_name:

	39 return k

	40 # Why is my builder not in here??

	41 return 'base-shuttle_ubuntu12_ati5770'
	scroggo 2013/06/24 17:43:16 Double hack, because my local builder was not foun Double hack, because my local builder was not found...
	42 # return None

	43

OLD	NEW