Run skimage on the bots.

slave/skia_slave_scripts/android_build_step.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Subclass for all slave-side Android build steps. """
 
 from build_step import BuildStep, DeviceDirs
 from utils import android_utils
 from utils import gs_utils
 from utils import shell_utils
@@ skipping 34 matching lines @@
       raise Exception('Failed to remove %s' % directory)
 
   def _CreateDirectoryOnDevice(self, directory):
     """ Create a directory on the device. """
     android_utils.RunADB(self._serial, ['shell', 'mkdir', '-p', directory])
 
   def PushFileToDevice(self, src, dst):
     """ Overrides build_step.PushFileToDevice() """
     android_utils.RunADB(self._serial, ['push', src, dst])
 
+  def DevicePathExists(self, path):
+    """ Overrides build_step.DevicePathExists() """
+    return posixpath.exists(path)

[borenet, 2013/06/26 18:47:31]

You'll need to run something in the ADB shell to do this, as posixpath is still
looking on the host side.  I think you can just move the implementation from
_RemoveDirectoryOnDevice.

[scroggo, 2013/06/26 20:07:08]

Done.

+
   def DevicePathJoin(self, *args):
     """ Overrides build_step.DevicePathJoin() """
     return posixpath.sep.join(args)
 
   def CreateCleanDirectory(self, directory):
     self._RemoveDirectoryOnDevice(directory)
     self._CreateDirectoryOnDevice(directory)
 
   def CopyDirectoryContentsToDevice(self, host_dir, device_dir):
     """ Copy the contents of a host-side directory to a clean directory on the
@@ skipping 19 matching lines @@
     device_scratch_dir = shell_utils.Bash(
         '%s -s %s shell echo \$EXTERNAL_STORAGE' % (
             android_utils.PATH_TO_ADB, self._serial), 
         echo=True, shell=True).rstrip().split('\n')[-1]
     super(AndroidBuildStep, self).__init__(args=args, **kwargs)
     prefix = posixpath.join(device_scratch_dir, 'skiabot', 'skia_')
     self._device_dirs = DeviceDirs(perf_data_dir=prefix + 'perf',
                                    gm_actual_dir=prefix + 'gm_actual',
                                    gm_expected_dir=prefix + 'gm_expected',
                                    resource_dir=prefix + 'resources',
+                                   skimage_in_dir=prefix + 'skimage_in',
+                                   skimage_expected_dir=(prefix
+                                                         + 'skimage_expected'),
+                                   skimage_out_dir=prefix + 'skimage_out',
                                    skp_dir=prefix + 'skp',
                                    skp_perf_dir=prefix + 'skp_perf',
                                    skp_out_dir=prefix + 'skp_out',
                                    tmp_dir=prefix + 'tmp_dir')