Chromium Code Reviews

Issue 1622593003: Revert of Add size check for PaintLayer (Closed)

Created:
4 years, 11 months ago by Scott Hess - ex-Googler
Modified:
4 years, 11 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add size check for PaintLayer (patchset #4 id:60001 of https://codereview.chromium.org/1616193002/ ) Reason for revert: "Chromium Webkit WebKit Linux Oilpan Builder failure" https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20Builder/builds/917/steps/compile/logs/stdio ../../third_party/WebKit/Source/core/paint/PaintLayer.cpp:125:1: error: static_assert failed "PaintLayer should stay small" static_assert(sizeof(PaintLayer) == sizeof(SameSizeAsPaintLayer), "PaintLayer should stay small"); Original issue's description: > Add size check for PaintLayer > > Committed: https://crrev.com/da42a3f1bb4756fb35f7ce4f90064f29eee87946 > Cr-Commit-Position: refs/heads/master@{#371103} TBR=chrishtr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2597aca0b1a69a79a7ace53c31dfb713cddf4156 Cr-Commit-Position: refs/heads/master@{#371111}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -32 lines)
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +0 lines, -32 lines 0 comments

Messages

Total messages: 6 (2 generated)
Scott Hess - ex-Googler
Created Revert of Add size check for PaintLayer
4 years, 11 months ago (2016-01-23 01:14:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622593003/1
4 years, 11 months ago (2016-01-23 01:15:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-23 01:17:02 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 01:19:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2597aca0b1a69a79a7ace53c31dfb713cddf4156
Cr-Commit-Position: refs/heads/master@{#371111}

Powered by Google App Engine