Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1622493002: [stubs] Introduce ToNameStub to implement %_ToName. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Introduce ToNameStub to implement %_ToName. We already had hand-written optimized code for %_ToName in fullcodegen, but the optimizing compilers always went to the runtime for %_ToName, which is pretty bad for many of our builtins. So this CL moves the existing native code to a ToNameStub (similar to the existing ToStringStub), and uses the ToNameStub consistently in all compilers to actually implement %_ToName. Committed: https://crrev.com/a0878333de4dd090f9d8987e1698a9eef9cc7219 Cr-Commit-Position: refs/heads/master@{#33460}

Patch Set 1 #

Patch Set 2 : Fix BuildNumberToString type in Crankshaft. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -123 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 chunks +25 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
Hey Jaro, Here's the %_ToName stuff, removing the runtime call overhead in the common case ...
4 years, 11 months ago (2016-01-22 09:17:52 UTC) #2
Jarin
lgtm
4 years, 11 months ago (2016-01-22 09:22:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622493002/20001
4 years, 11 months ago (2016-01-22 09:35:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 09:52:20 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 09:52:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0878333de4dd090f9d8987e1698a9eef9cc7219
Cr-Commit-Position: refs/heads/master@{#33460}

Powered by Google App Engine
This is Rietveld 408576698