Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1622483002: Revert[2] of float color components (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[2] of float color components This reverts commit 2a2bdc698460c38ac9e24ba4abdeefec67bcba37. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1622483002 TBR= NOTRY=True Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot seems wicked slow Committed: https://skia.googlesource.com/skia/+/6d3cef930ad19b0f55543ca40f7a07030f4fe508

Patch Set 1 #

Patch Set 2 : fix inversion of unpremul check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -19 lines) Patch
M include/core/SkColor.h View 1 chunk +40 lines, -0 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +4 lines, -1 line 0 comments Download
M include/core/SkColorPriv.h View 1 chunk +5 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 2 chunks +3 lines, -0 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColor.cpp View 1 chunk +34 lines, -0 lines 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkColorShader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkMathPriv.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkShader.cpp View 3 chunks +15 lines, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 3 chunks +43 lines, -17 lines 0 comments Download
A tests/SkColor4fTest.cpp View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622483002/20001
4 years, 11 months ago (2016-01-22 08:46:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622483002/20001
4 years, 11 months ago (2016-01-22 08:57:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622483002/20001
4 years, 11 months ago (2016-01-22 09:03:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6d3cef930ad19b0f55543ca40f7a07030f4fe508
4 years, 11 months ago (2016-01-22 09:04:31 UTC) #13
cbiesinger
On 2016/01/22 09:04:31, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
4 years, 11 months ago (2016-01-22 20:27:27 UTC) #14
mtklein
4 years, 11 months ago (2016-01-22 22:04:36 UTC) #15
Message was sent while issue was closed.
On 2016/01/22 20:27:27, cbiesinger wrote:
> On 2016/01/22 09:04:31, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
https://skia.googlesource.com/skia/+/6d3cef930ad19b0f55543ca40f7a07030f4fe508
> 
> I believe this caused various crashes on Linux32:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032
> 
> Please investigate! I don't know how to revert Skia changes unfortunately.

I believe this was fixed by rolling https://codereview.chromium.org/1618873005
into Chrome
(https://chromium.googlesource.com/chromium/src/+/43b1f8e6a7b03da7a96b6c66331d...).

Reverting a Skia change is just like reverting a Chrome change, I think.  Click
Revert Patchset, explain why, and if the whims of the system require it, get
someone to LGTM the revert.  (I never know who can revert which CLs without
review...)

Powered by Google App Engine
This is Rietveld 408576698