Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1622433002: views: Remove unused GetCurrentTargetForAccelerator from FocusManager. (Closed)

Created:
4 years, 11 months ago by sadrul
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Remove unused GetCurrentTargetForAccelerator from FocusManager. BUG=none Committed: https://crrev.com/7c7dde9494872e8b67d47a30d64cd9013d289885 Cr-Commit-Position: refs/heads/master@{#389287}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -169 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M ash/accelerators/focus_manager_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/accelerators/focus_manager_factory.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/find_bar_controller_interactive_uitest.cc View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/accelerators/accelerator_manager.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M ui/base/accelerators/accelerator_manager.cc View 1 2 3 chunks +6 lines, -8 lines 0 comments Download
M ui/views/focus/focus_manager.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/focus/focus_manager.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/focus/focus_manager_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 1 2 3 13 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sadrul
I forgot to send out this cleanup CL from a few months back for review, ...
4 years, 8 months ago (2016-04-22 17:04:42 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-22 19:18:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622433002/60001
4 years, 8 months ago (2016-04-22 23:01:43 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-22 23:08:20 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 23:10:26 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/7c7dde9494872e8b67d47a30d64cd9013d289885
Cr-Commit-Position: refs/heads/master@{#389287}

Powered by Google App Engine
This is Rietveld 408576698