chrome/browser/engagement/site_engagement_helper_unittest.cc - Issue 1622413002: Update user input event's engagement value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper_unittest.cc

Issue 1622413002: Update user input event's engagement value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@first_nav_bonus

Patch Set: address nits Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/engagement/site_engagement_helper_unittest.cc

diff --git a/chrome/browser/engagement/site_engagement_helper_unittest.cc b/chrome/browser/engagement/site_engagement_helper_unittest.cc

index 4ad1676f9402b6a228aeb91ce38b1d9e9bd044cf..db00c5968deaafa506e3e8fd6276bcdd1004c011 100644

--- a/chrome/browser/engagement/site_engagement_helper_unittest.cc

+++ b/chrome/browser/engagement/site_engagement_helper_unittest.cc

@@ -22,7 +22,7 @@ class SiteEngagementHelperTest : public ChromeRenderViewHostTestHarness {

public:

void SetUp() override {

ChromeRenderViewHostTestHarness::SetUp();

- SiteEngagementScore::DisableFirstDailyEngagementBonusForTesting();

+ SiteEngagementScore::SetParamValuesForTesting();

}

SiteEngagementHelper* GetHelper(content::WebContents* web_contents) {

« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_service.h » ('j') | no next file with comments »