Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 16224009: [NaCl SDK] Roll naclports revision built into NaCl SDK (Closed)

Created:
7 years, 6 months ago by Sam Clegg
Modified:
7 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, binji
Visibility:
Public.

Description

[NaCl SDK] Roll naclports revision built into NaCl SDK r757 -> r774 This fixes a recent breakage regarding the name of the ncval executable changing. It also brings in several other changes from naclports but none should directly effect any of the packages included in the SDK. BUG=None TEST=build_sdk.py --build-ports R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
7 years, 6 months ago (2013-06-04 19:23:55 UTC) #1
binji
lgtm
7 years, 6 months ago (2013-06-04 19:24:47 UTC) #2
Sam Clegg
7 years, 6 months ago (2013-06-04 19:32:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r204018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698