[GCM] Remove all persisted data and close connections when signing out of a profile

[GCM] Remove all persisted data and close connections when signing out of a profile

When a profile is being signed out, we need to:
1) Close all the requests and connections.
2) Delete the GCM store.
3) Delete the persisted registration info (sender IDs and
   registration ID) from the app's state store.
4) Delete the persisted data from prefs store

To support 3, we need to remember the IDs of all registered
apps. As the result, I added the code to write the IDs of
all registered apps to the prefs store.

Also due to this change, we do not need to listen to 
NOTIFICATION_EXTENSION_LOADED and load the registration info
when the app is loaded because we will restore all the app
IDs and then read all the registration info when GCMProfileService
starts. This also makes us support other types of apps.

BUG=284553
TEST=new tests added

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250958

[fgorski, 2014-02-13 00:20:08]

https://codereview.chromium.org/162233002/diff/150001/chrome/browser/services...
File chrome/browser/services/gcm/gcm_profile_service.cc (left):

https://codereview.chromium.org/162233002/diff/150001/chrome/browser/services...
chrome/browser/services/gcm/gcm_profile_service.cc:517:
chrome::NOTIFICATION_EXTENSION_LOADED,
please edit the CL description to cover why you are going this.

https://codereview.chromium.org/162233002/diff/150001/chrome/browser/services...
File chrome/browser/services/gcm/gcm_profile_service.cc (right):

https://codereview.chromium.org/162233002/diff/150001/chrome/browser/services...
chrome/browser/services/gcm/gcm_profile_service.cc:781: // Remove the persisted
registration info.
WriteRegisteredAppIDs from here as well, given that you've just removed one.

https://codereview.chromium.org/162233002/diff/150001/google_apis/gcm/gcm_cli...
File google_apis/gcm/gcm_client_impl.cc (right):

https://codereview.chromium.org/162233002/diff/150001/google_apis/gcm/gcm_cli...
google_apis/gcm/gcm_client_impl.cc:276: mcs_client_->Destroy();  // This will
also destroy GCM store.
Given the ownership of GCMStore the comment sounds like a documentation of a
side effect, could you add a TODO to the MCS client destroy, that we should move
part of the functionality to GCMClient::Destroy?

[jianli, 2014-02-13 00:32:47]

https://codereview.chromium.org/162233002/diff/150001/chrome/browser/services...
File chrome/browser/services/gcm/gcm_profile_service.cc (left):

https://codereview.chromium.org/162233002/diff/150001/chrome/browser/services...
chrome/browser/services/gcm/gcm_profile_service.cc:517:
chrome::NOTIFICATION_EXTENSION_LOADED,
On 2014/02/13 00:20:12, Filip Gorski wrote:
> please edit the CL description to cover why you are going this.

Done.

https://codereview.chromium.org/162233002/diff/150001/chrome/browser/services...
File chrome/browser/services/gcm/gcm_profile_service.cc (right):

https://codereview.chromium.org/162233002/diff/150001/chrome/browser/services...
chrome/browser/services/gcm/gcm_profile_service.cc:781: // Remove the persisted
registration info.
On 2014/02/13 00:20:12, Filip Gorski wrote:
> WriteRegisteredAppIDs from here as well, given that you've just removed one.

Good catch. Done.

https://codereview.chromium.org/162233002/diff/150001/google_apis/gcm/gcm_cli...
File google_apis/gcm/gcm_client_impl.cc (right):

https://codereview.chromium.org/162233002/diff/150001/google_apis/gcm/gcm_cli...
google_apis/gcm/gcm_client_impl.cc:276: mcs_client_->Destroy();  // This will
also destroy GCM store.
On 2014/02/13 00:20:12, Filip Gorski wrote:
> Given the ownership of GCMStore the comment sounds like a documentation of a
> side effect, could you add a TODO to the MCS client destroy, that we should
move
> part of the functionality to GCMClient::Destroy?

Done.

[fgorski, 2014-02-13 00:34:27]

lgtm

[Nicolas Zea, 2014-02-13 01:24:59]

LGTM with a nit

https://codereview.chromium.org/162233002/diff/230001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/162233002/diff/230001/chrome/common/pref_name...
chrome/common/pref_names.cc:1306: // Apps that use GCM.
nit: I think "Registered GCM application ids" is clearer
and maybe the pref name should be gcm.registered_app_ids

[jianli, 2014-02-13 01:39:51]

The CQ bit was checked by jianli@chromium.org

[jianli, 2014-02-13 01:40:50]

The CQ bit was unchecked by jianli@chromium.org

[jianli, 2014-02-13 01:45:40]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-02-13 01:51:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jianli@chromium.org/162233002/490001

[commit-bot: I haz the power, 2014-02-13 02:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 02:48:41]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chrome_elf_unittests, chromedriver_unittests, components_unittests,
compositor_unittests, content_browsertests, content_unittests, crypto_unittests,
events_unittests, google_apis_unittests, gpu_unittests,
installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[jianli, 2014-02-13 03:43:54]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-02-13 03:45:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jianli@chromium.org/162233002/490001

[commit-bot: I haz the power, 2014-02-13 05:21:05]

Change committed as 250958