Add minimal yaml support to the engine

Add minimal yaml support to the engine

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/032aa117116dd221d1fbf86506295abeab817b14

[Brian Wilkerson, 2016-01-24 17:01:07]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[Brian Wilkerson, 2016-01-24 17:01:07]

This adds minimal support for yaml to the analysis engine. It does not cause any
yaml files to be automatically analyzed, but allows results to be explicitly
requested.

This is one step toward moving the non-rule portion of the linter into the
analysis engine.

It will also allow the linter to use the existing LineInfo class instead of
providing an alternative implementation.

[scheglov, 2016-01-24 18:20:44]

LGTM

https://codereview.chromium.org/1622313003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/yaml_test.dart (right):

https://codereview.chromium.org/1622313003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/yaml_test.dart:36: expect(outputs[YAML_LINE_INFO],
isNotNull);
These expect(s) and in the test below are IMHO too weak.

https://codereview.chromium.org/1622313003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/yaml_test.dart:49: source =
resourceProvider.getFile('/test.dart').createSource();
test.yaml ?

[Brian Wilkerson, 2016-01-24 23:14:44]

https://codereview.chromium.org/1622313003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/yaml_test.dart (right):

https://codereview.chromium.org/1622313003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/yaml_test.dart:36: expect(outputs[YAML_LINE_INFO],
isNotNull);
True. More complete tests added.

https://codereview.chromium.org/1622313003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/yaml_test.dart:49: source =
resourceProvider.getFile('/test.dart').createSource();
Done

[Paul Berry, 2016-01-25 12:40:01]

lgtm

[Brian Wilkerson, 2016-01-25 17:00:50]

Description was changed from

==========
Add minimal yaml support to the engine
==========

to

==========
Add minimal yaml support to the engine

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/032aa117116dd221d1fbf86506295abeab817b14
==========

[Brian Wilkerson, 2016-01-25 17:00:52]

Committed patchset #2 (id:20001) manually as
032aa117116dd221d1fbf86506295abeab817b14 (presubmit successful).