Implement WebFrameClient in RenderFrameImpl and proxy all calls to RenderView.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 864 matching lines @@
 
   g_view_map.Get().insert(std::make_pair(webview(), this));
   g_routing_id_view_map.Get().insert(std::make_pair(routing_id_, this));
   webview()->setDeviceScaleFactor(device_scale_factor_);
   webview()->settings()->setAcceleratedCompositingForFixedPositionEnabled(
       ShouldUseFixedPositionCompositing(device_scale_factor_));
   webview()->settings()->setAcceleratedCompositingForTransitionEnabled(
       ShouldUseTransitionCompositing(device_scale_factor_));
 
   webkit_glue::ApplyWebPreferences(webkit_preferences_, webview());
-  webview()->initializeMainFrame(this);
+  webview()->initializeMainFrame(main_render_frame_.get());

[Charlie Reis, 2013/06/12 20:32:29]

Does RenderViewImpl still need to derive from WebFrameClient?  I know all its
WebFrameClient methods will stick around for a while, but that will let us start
removing them one-by-one.

[nasko, 2013/06/12 21:36:00]

I didn't want to touch the header file for RenderViewImpl for this change. If I
remove the derivation, I need to remove a bunch of OVERRIDE keywords. I agree it
shouldn't derive and if you feel the code churn is worth now, I'll do it.

[Charlie Reis, 2013/06/12 22:16:10]

I think we might as well.  It's conceptually tied to what you're doing here,
makes it so we keep only one WebFrameClient implementation, and sets you up to
start moving methods.

 
   if (switches::IsTouchDragDropEnabled())
     webview()->settings()->setTouchDragDropEnabled(true);
 
   if (switches::IsTouchEditingEnabled())
     webview()->settings()->setTouchEditingEnabled(true);
 
   if (!params->frame_name.empty())
     webview()->mainFrame()->setName(params->frame_name);
 
@@ skipping 5833 matching lines @@
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 
 }  // namespace content