Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: third_party/WebKit/Source/core/inspector/InjectedScriptManager.h

Issue 1622213002: DevTools: make InjectedScript heap-allocated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InjectedScriptManager.h
diff --git a/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h b/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h
index d0f389624d291d121309c9780b2a7005d64650e8..c87dd67bf44b7739b432439070137bab915c2e0e 100644
--- a/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h
+++ b/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h
@@ -57,9 +57,9 @@ public:
InjectedScriptHost* injectedScriptHost();
- InjectedScript injectedScriptFor(ScriptState*);
- InjectedScript findInjectedScript(int) const;
- InjectedScript findInjectedScript(RemoteObjectIdBase*) const;
+ InjectedScript* injectedScriptFor(ScriptState*);
+ InjectedScript* findInjectedScript(int) const;
+ InjectedScript* findInjectedScript(RemoteObjectIdBase*) const;
void discardInjectedScripts();
int discardInjectedScriptFor(ScriptState*);
void releaseObjectGroup(const String& objectGroup);
@@ -78,7 +78,7 @@ private:
static bool canAccessInspectedWindow(ScriptState*);
static bool canAccessInspectedWorkerGlobalScope(ScriptState*);
- typedef HashMap<int, InjectedScript> IdToInjectedScriptMap;
+ typedef HashMap<int, OwnPtr<InjectedScript>> IdToInjectedScriptMap;
IdToInjectedScriptMap m_idToInjectedScript;
RefPtr<InjectedScriptHost> m_injectedScriptHost;
InspectedStateAccessCheck m_inspectedStateAccessCheck;

Powered by Google App Engine
This is Rietveld 408576698