Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 162213002: Change mojo demo apps to use Application. (Closed)

Created:
6 years, 10 months ago by DaveMoore
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Change mojo demo apps to use Application. BUG=None R=darin@chromium.org, ben Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251076

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add shell() to ServiceFactory::Owner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -114 lines) Patch
M mojo/examples/aura_demo/aura_demo.cc View 1 4 chunks +6 lines, -14 lines 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 3 chunks +31 lines, -54 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 6 chunks +9 lines, -10 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/view_manager/view_manager.cc View 1 7 chunks +10 lines, -21 lines 0 comments Download
M mojo/public/shell/application.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M mojo/public/shell/lib/application.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M mojo/public/shell/lib/service.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/shell/service.h View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
DaveMoore
There are some choices made here about how to deal with stub applications that only ...
6 years, 10 months ago (2014-02-12 23:51:13 UTC) #1
darin (slow to review)
LGTM. I suspect Ben will also approve of the simplification. https://codereview.chromium.org/162213002/diff/1/mojo/public/shell/service.h File mojo/public/shell/service.h (right): https://codereview.chromium.org/162213002/diff/1/mojo/public/shell/service.h#newcode156 ...
6 years, 10 months ago (2014-02-13 00:05:38 UTC) #2
DaveMoore
Add shell() to ServiceFactory::Owner
6 years, 10 months ago (2014-02-13 15:35:59 UTC) #3
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 10 months ago (2014-02-13 15:56:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/162213002/60001
6 years, 10 months ago (2014-02-13 15:57:16 UTC) #5
DaveMoore
6 years, 10 months ago (2014-02-13 17:56:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r251076 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698