components/autofill/core/browser/form_field.cc - Issue 1622073002: [Autofill] Remove longest common prefix from field names when running heuristics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_field.cc

Issue 1622073002: [Autofill] Remove longest common prefix from field names when running heuristics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_field.h ('K') | « components/autofill/core/browser/autofill_field.cc ('k') | components/autofill/core/browser/form_structure.h » ('j') | components/autofill/core/browser/form_structure.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_field.cc

diff --git a/components/autofill/core/browser/form_field.cc b/components/autofill/core/browser/form_field.cc

index 50d7e8a30a81cf74343e3656627695840085f9cf..fd43fc1dc093a0ab973dbcbc7fb28bbaa37d6824 100644

--- a/components/autofill/core/browser/form_field.cc

+++ b/components/autofill/core/browser/form_field.cc

@@ -185,7 +185,7 @@ bool FormField::Match(const AutofillField* field,

}

if ((match_type & FormField::MATCH_NAME) &&

- MatchesPattern(field->name, pattern)) {

+ MatchesPattern(field->parseable_name(), pattern)) {

return true;

}