[Autofill] Remove longest common prefix from field names when running heuristics.

components/autofill/core/browser/autofill_field.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
 
 #include <stddef.h>
 
 #include <string>
@@ skipping 22 matching lines @@
   const base::string16& unique_name() const { return unique_name_; }
 
   const std::string& section() const { return section_; }
   ServerFieldType heuristic_type() const { return heuristic_type_; }
   ServerFieldType server_type() const { return server_type_; }
   HtmlFieldType html_type() const { return html_type_; }
   HtmlFieldMode html_mode() const { return html_mode_; }
   const ServerFieldTypeSet& possible_types() const { return possible_types_; }
   PhonePart phone_part() const { return phone_part_; }
   bool previously_autofilled() const { return previously_autofilled_; }
+  const base::string16& parseable_name() const { return parseable_name_; }
 
   // Setters for the detected type and section for this field.
   void set_section(const std::string& section) { section_ = section; }
   void set_heuristic_type(ServerFieldType type);
   void set_server_type(ServerFieldType type);
   void set_possible_types(const ServerFieldTypeSet& possible_types) {
     possible_types_ = possible_types;
   }
   void SetHtmlType(HtmlFieldType type, HtmlFieldMode mode);
   void set_previously_autofilled(bool previously_autofilled) {
     previously_autofilled_ = previously_autofilled;
   }
+  void set_parseable_name(const base::string16& parseable_name) {

[vabr (Chromium), 2016/01/25 10:10:25]

nit: passing by value and using std::move is potentially avoiding a copy:

case 1 -- if the argument is a temporary, then passing by value + move makes 0
copies, unlike the current code

case 2 -- otherwise, there is 1 copy in both versions of code (only it happens
during calling with pass by value + move, and on line 57 in the current code)

[Mathieu, 2016/01/25 15:52:53]

Done.

+    parseable_name_ = parseable_name;
+  }
 
   // This function automatically chooses between server and heuristic autofill
   // type, depending on the data available.
   AutofillType Type() const;
 
   // Returns true if the value of this field is empty.
   bool IsEmpty() const;
 
   // The unique signature of this field, composed of the field name and the html
   // input type in a 32-bit hash.
@@ skipping 67 matching lines @@
   // The default value returned by the Autofill server.
   std::string default_value_;
 
   // Used to hold the position of the first digit to be copied as a substring
   // from credit card number.
   size_t credit_card_number_offset_;
 
   // Whether the field was autofilled then later edited.
   bool previously_autofilled_;
 
+  // The parseable name attribute, with unnecessary information removed (such as
+  // a common prefix shared with other fields). Will be used for heuristics
+  // parsing.
+  base::string16 parseable_name_;
+
   DISALLOW_COPY_AND_ASSIGN(AutofillField);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_