Issue 1622030: Made ThemeChangeProcessor handle multiple updates to work around

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1622030: Made ThemeChangeProcessor handle multiple updates to work around (Closed)

Created:
10 years, 8 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews

Visibility:
Public.

Made ThemeChangeProcessor handle multiple updates to work around a problem with the syncapi. BUG=41439 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44736

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -16 lines)			Patch
	M	chrome/browser/sync/glue/theme_change_processor.cc	View	1	1 chunk	+29 lines, -16 lines	0 comments	Download

Total messages: 3 (0 generated)

akalin

On 2010/04/15 23:26:57, akalin wrote: > +nick for review -nick +tim

10 years, 8 months ago (2010-04-16 00:09:08 UTC) #2

tim (not reviewing)

10 years, 8 months ago (2010-04-16 00:36:56 UTC) #3

LGTM
it would be nice to have a test for this, but we don't have any tests for the
ApplyChanges path :(