Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: patches/pkg_gen.patch

Issue 1621943002: ICU 56 step 4: Apply post-56 fixes for measure/date format (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@56goog
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « patches/mutex.patch ('k') | patches/platform_nacl.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 diff --git a/source/tools/toolutil/pkg_genc.c b/source/tools/toolutil/pkg_genc.c
2 index e211403..ddc6941 100644
3 --- a/source/tools/toolutil/pkg_genc.c
4 +++ b/source/tools/toolutil/pkg_genc.c
5 @@ -119,7 +119,11 @@ static const struct AssemblyType {
6 ".globl %s\n"
7 "\t.section .note.GNU-stack,\"\",%%progbits\n"
8 "\t.section .rodata\n"
9 - "\t.balign 16\n"
10 + "\t.balign 16\n"
11 + /* The 3 lines below are added for Chrome. */
12 + "#ifdef U_HIDE_DATA_SYMBOL\n"
13 + "\t.hidden %s\n"
14 + "#endif\n"
15 "\t.type %s,%%object\n"
16 "%s:\n\n",
17
18 @@ -129,6 +133,10 @@ static const struct AssemblyType {
19 /*"\t.section __TEXT,__text,regular,pure_instructions\n"
20 "\t.section __TEXT,__picsymbolstub1,symbol_stubs,pure_instructions,32\n "*/
21 ".globl _%s\n"
22 + /* The 3 lines below are added for Chrome. */
23 + "#ifdef U_HIDE_DATA_SYMBOL\n"
24 + "\t.private_extern _%s\n"
25 + "#endif\n"
26 "\t.data\n"
27 "\t.const\n"
28 "\t.balign 16\n"
29 @@ -264,7 +272,7 @@ writeAssemblyCode(const char *filename, const char *destdir, const char *optEntr
30 exit(U_FILE_ACCESS_ERROR);
31 }
32
33 - getOutFilename(filename, destdir, bufferStr, entry, ".s", optFilename);
34 + getOutFilename(filename, destdir, bufferStr, entry, ".S", optFilename);
35 out=T_FileStream_open(bufferStr, "w");
36 if(out==NULL) {
37 fprintf(stderr, "genccode: unable to open output file %s\n", bufferStr) ;
OLDNEW
« no previous file with comments | « patches/mutex.patch ('k') | patches/platform_nacl.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698