Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: README.chromium

Issue 1621943002: ICU 56 step 4: Apply post-56 fixes for measure/date format (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@56goog
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | patches/bidi.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name: icu 1 Name: icu
2 URL: http://site.icu-project.org/ 2 URL: http://site.icu-project.org/
3 Version: 54.1 3 Version: 56.1
4 License: MIT 4 License: MIT
5 Security Critical: yes 5 Security Critical: yes
6 6
7 ***NOTE***
8 ICU is in the middle of being updated to 56.1 and does not work, yet.
9 If you have an urgent fix to apply, contact jshin@chromium.org to
10 create a branch for 54.1 to apply a fix on top of.
11
7 Description: 12 Description:
8 This directory contains the source code of ICU 54.1 for C/C++. 13 This directory contains the source code of ICU 56.1 for C/C++.
9 14
10 15
11 1. Run "scripts/update.sh <version>" (e.g. 54-1). 16 1. Run "scripts/update.sh <version>" (e.g. 56-1).
12 17
13 2. Apply the following patch for platform.h for NaCl. 18 2. Apply locale data patches from Google obtained by diff'ing
19 the upstream copy and Google's internal copy for source/data
14 20
15 - patches/platform_nacl.patch to add U_PF_NATIVE_CLIENT 21 - patches/locale_google.patch:
16 - upstream bug (fixed in the upstream 55 RC) 22 * Google's internal ICU locale changes
17 http://bugs.icu-project.org/trac/ticket/11033 23 * Simpler region names for Hong Kong and Macau in all locales
24 * Currency signs in ru, uk and tr locales
25 * AM/PM, midnight, noon formatting for a few Indian locales
26 * Timezone name changes in Korean and Chinese locales
18 27
28 - patches/locale1.patch: Minor fixes for Korean
29
30
31 3. Apply post-56 fixes from the upstream for measure/date format bugs
32
33 - patches/measure_format.patch: combined patch of 12 CLs taken
34 from bugs below.
35 - upstream bugs
36 http://bugs.icu-project.org/trac/ticket/11986
37 http://bugs.icu-project.org/trac/ticket/12031
38 http://bugs.icu-project.org/trac/ticket/12030
39 http://bugs.icu-project.org/trac/ticket/12041
40
41 - patches/relative_date.patch from Android
42 https://android.googlesource.com/platform/external/icu/+/f9ffd5b%5E%21
19 43
20 3. Breakiterator patches 44 3. Breakiterator patches
21 45
22 - Apply patches/brkitr.patch 46 - Apply patches/brkitr.patch
23 * word.txt 47 * word.txt
24 a. Move full stops (U+002E, U+FF0E) from MidNumLet to MidNum so that 48 a. Move full stops (U+002E, U+FF0E) from MidNumLet to MidNum so that
25 FQDN labels can be split at '.' 49 FQDN labels can be split at '.'
26 b. Move fullwidth digits (U+FF10 - U+FF19) from Ideographic to Numeric. 50 b. Move fullwidth digits (U+FF10 - U+FF19) from Ideographic to Numeric.
27 See http://unicode.org/cldr/trac/ticket/6555 51 See http://unicode.org/cldr/trac/ticket/6555
28 * line.txt 52 * line.txt
29 a. Use Japanese rules for all locales because Japanese tailoring only 53 a. Use Japanese rules for all locales because Japanese tailoring only
30 affects Japanese specific characters. 54 affects Japanese specific characters.
31 See http://unicode.org/cldr/trac/ticket/3974 55 See http://unicode.org/cldr/trac/ticket/3974
32 b. Minor changes in CL, OP and IS definitions to handle 'comma-variants' 56 b. Minor changes in CL, OP and IS definitions to handle 'comma-variants'
33 more consistenly. 57 more consistenly.
34 See http://unicode.org/cldr/trac/ticket/6557 58 See http://unicode.org/cldr/trac/ticket/6557
35 c. Fix line breaking for Chinese characters and quotation marks 59 c. Fix line breaking for Chinese characters and quotation marks
36 See http://unicode.org/cldr/trac/ticket/4200 and 60 See http://unicode.org/cldr/trac/ticket/4200 and
37 http://crbug.com/39779 61 http://crbug.com/39779
38 62
39 - Add a new file brklocal.mk (copied from brkfiles.mk) with line_ja.txt 63 - Add a new file brklocal.mk (copied from brkfiles.mk) with line_ja.txt
40 and word_POSIX.txt dropped from the build list. 64 and word_POSIX.txt dropped from the build list.
41 65
42 - Apply patches/khmer-dictbe.patch and put in a smaller Khmer dictionary 66 - Apply patches/khmer-dictbe.patch and put in a smaller Khmer dictionary
43 (source/data/brkitr/khmerdict.txt) obtained from 67 (source/data/brkitr/khmerdict.txt) obtained from
44 http://bugs.icu-project.org/trac/ticket/9451 68 http://bugs.icu-project.org/trac/ticket/9451
45 69
46 - Add several common Chinese words that were dropped previously to 70 - Add several common Chinese words that were dropped previously to
47 source/data/cjdict/brkitr/cjdict.txt 71 source/data/cjdict/brkitr/cjdict.txt
48 patch: patches/cjdict.patch 72 patch: patches/cjdict.patch
49 upstream bug: http://bugs.icu-project.org/trac/ticket/10888 73 upstream bug: http://bugs.icu-project.org/trac/ticket/10888
50 74
51 75
52 - android/brkitr.patch (to be applied for Android build only) : 76 - android/brkitr.patch (to be applied for Android build only) :
53 Do not use the C+J dictionary for Chinese/Japanese segmentation 77 Do not use the C+J dictionary for Chinese/Japanese segmentation
54 to reduce the data size. Adjust word.txt and a few other files. 78 to reduce the data size. Adjust word.txt and a few other files.
55 79
56 - source/data/brkitr/word_ja.txt (used only on Android) 80 - source/data/brkitr/word_ja.txt (used only on Android)
57 Added for Japanese-specific word-breaking without the C+J dictionary. 81 Added for Japanese-specific word-breaking without the C+J dictionary.
58 82
59 4. Converter changes : 83 4. Converter changes :
60 84
61 - convrtrs.txt : Replaced the original by our own that only lists encodings 85 - convrtrs.txt : Replaced the original by our own that only lists encodings
62 and aliases required by the WHATWG Encoding spec plus a few extra (see 86 and aliases required by the WHATWG Encoding spec plus a few extra (see
63 the file as to why). 87 the file as to why).
64 88
65 - Add source/data/mappings/ucmlocal.txt : to list only converters we need. 89 - Add source/data/mappings/ucmlocal.txt : to list only converters we need.
66 90
67 - Add new tables per the WHATWG encoding standards for EUC-JP, 91 - Add new tables per the WHATWG encoding standards for EUC-JP,
(...skipping 17 matching lines...) Expand all
85 - Upstream bugs 109 - Upstream bugs
86 http://www.icu-project.org/trac/ticket/11296 (uconv.patch) 110 http://www.icu-project.org/trac/ticket/11296 (uconv.patch)
87 http://www.icu-project.org/trac/ticket/10303 (html5 encoding tables) 111 http://www.icu-project.org/trac/ticket/10303 (html5 encoding tables)
88 112
89 uconv.patch was landed in the upstream and is in 55 RC with the build 113 uconv.patch was landed in the upstream and is in 55 RC with the build
90 config changed to UCONFIG_ONLY_HTML_CONVERSION. 114 config changed to UCONFIG_ONLY_HTML_CONVERSION.
91 115
92 116
93 5. Locale changes 117 5. Locale changes
94 118
95 - patches/locale_google.patch : Google's internal ICU locale changes
96
97 - patches/locale1.patch :
98 a. Exemplar character set changes for zh*, ja + 9 Indian locales
99 b. Minor fixes for Korean and Turkish
100
101 - Locale build configuration files: To include the full locale data 119 - Locale build configuration files: To include the full locale data
102 for Chrome's UI languages and the minimum locale data for other locales, 120 for Chrome's UI languages and the minimum locale data for other locales,
103 add reslocal.mk or {trns,sprep,rbnf,coll}local.mk files to 121 add reslocal.mk or {trns,sprep,rbnf,coll}local.mk files to
104 source/data/{coll,curr,lang.locale,curr,region,translit,zone,rbnf,sprep}. 122 source/data/{coll,curr,lang.locale,curr,region,translit,zone,rbnf,sprep}.
105 123
106 This along with #8 (data.build.patch), #3 (brkiter) and #4 (converter) 124 This along with #8 (data.build.patch), #3 (brkiter) and #4 (converter)
107 cuts down the data size by ~ 11MB. 125 cuts down the data size by ~ 11MB.
108 126
109 - Run scripts/trim_data.sh : About 2.1MB data size reduction. 127 - Run scripts/trim_data.sh : About 2.1MB data size reduction.
110 a. Trim the locale data for Chrome's UI langauges : 128 a. Trim the locale data for Chrome's UI langauges :
(...skipping 21 matching lines...) Expand all
132 150
133 6. Timezone data update 151 6. Timezone data update
134 - Grab the latest version of the following timezone data files and 152 - Grab the latest version of the following timezone data files and
135 put them in source/data/misc using scripts/update_tz.sh 153 put them in source/data/misc using scripts/update_tz.sh
136 154
137 metaZones.txt 155 metaZones.txt
138 timezoneTypes.txt 156 timezoneTypes.txt
139 windowsZones.txt 157 windowsZones.txt
140 zoneinfo64.txt 158 zoneinfo64.txt
141 159
142 As of Dec 14 2015, the latest version is 2015g and the above files 160 As of Jan 20 2016, the latest version is 2015g and the above files
143 are available at 161 are available at
144 http://source.icu-project.org/repos/icu/data/trunk/tzdata/icunew/2015g/44/ 162 http://source.icu-project.org/repos/icu/data/trunk/tzdata/icunew/2015g/44/
145 163
146 7. Transliterator customization 164 7. Transliterator customization
147 165
148 - Also add css3transform.txt to source/data/trnslit. 166 - Also add css3transform.txt to source/data/trnslit.
149 - Put the following line in trnslocal.mk 167 - Put the following line in trnslocal.mk
150 168
151 TRANSLIT_SOURCE=css3transform.txt 169 TRANSLIT_SOURCE=css3transform.txt
152 170
153 8. Build-related changes 171 8. Build-related changes
154 172
155 - patches/wpo.patch 173 - patches/wpo.patch
156 upstream bugs : http://bugs.icu-project.org/trac/ticket/8043 174 upstream bugs : http://bugs.icu-project.org/trac/ticket/8043
157 http://bugs.icu-project.org/trac/ticket/5701 175 http://bugs.icu-project.org/trac/ticket/5701
158 - patches/vscomp.patch for building with Visual Studio on Windows. 176 - patches/vscomp.patch for building with Visual Studio on Windows.
159 a. do not use WINDOWS_LOCALE_API in locmap.c 177 a. do not use WINDOWS_LOCALE_API in locmap.c
160 b. do not redefine stringpiece::npos 178 b. do not redefine stringpiece::npos
161 c. Fix 'signed vs unsigned comparison' warning in 179 c. Fix 'signed vs unsigned comparison' warning in
162 collationfastlatin.cpp. The upstream ToT does not have these lines 180 collationfastlatin.cpp. The upstream ToT does not have these lines
163 any more. 181 any more.
164 d. Add static_cast to avoid a possible data truncatiion warning 182 d. Add static_cast to avoid a possible data truncatiion warning
165 upstream bug (fixed in the upstream 55 RC) 183 upstream bug (fixed in the upstream 55 RC)
166 http://bugs.icu-project.org/trac/ticket/11104 184 http://bugs.icu-project.org/trac/ticket/11104
167 185
168 - patches/data.build.patch : 186 - patches/data.build.patch :
169 Remove unnecessary resources : unames, collator rule source 187 Remove unnecessary resources : unames, collator rule source
170 - patches/pkg_gen.patch :
171 upstream bug (fixed in the upstream RC 55)
172 http://bugs.icu-project.org/trac/ticket/10572
173 - patches/data.build.win.patch : 188 - patches/data.build.win.patch :
174 Windows-only data build patch. 189 Windows-only data build patch.
175 - patches/data_symb.patch : 190 - patches/data_symb.patch :
176 Put ICU_DATA_ENTRY_POINT(icudtXX_dat) in common when we use 191 Put ICU_DATA_ENTRY_POINT(icudtXX_dat) in common when we use
177 the icu data file or icudt.dll 192 the icu data file or icudt.dll
178 193
179 9. Pre-built data files are checked in with the following steps on Linux: 194 9. Pre-built data files are checked in with the following steps on Linux:
180 195
181 a. Make a icu data build directory outside the Chromium source tree 196 a. Make a icu data build directory outside the Chromium source tree
182 and cd to that directory, $ICUBUILDIR. 197 and cd to that directory, $ICUBUILDIR.
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 ${SEPARATE_ICU_ROOT}/source/data/in/icudt54l.dat 247 ${SEPARATE_ICU_ROOT}/source/data/in/icudt54l.dat
233 c. copy ${CHROME_ICU_ROOT}/source/data/makedata.mak to 248 c. copy ${CHROME_ICU_ROOT}/source/data/makedata.mak to
234 ${SEPARATE_ICU_ROOT}/source/data/makedata.mak 249 ${SEPARATE_ICU_ROOT}/source/data/makedata.mak
235 c. In Visual Studio, open source/allinone/allinone.sln solution 250 c. In Visual Studio, open source/allinone/allinone.sln solution
236 in ${SEPARATE_ICU_ROOT} 251 in ${SEPARATE_ICU_ROOT}
237 d. Build 'makedata' target 252 d. Build 'makedata' target
238 e. icudt54.dll will be generated in ${SEPARATE_ICU_ROOT}/bin 253 e. icudt54.dll will be generated in ${SEPARATE_ICU_ROOT}/bin
239 f. Copy that icudt54.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll 254 f. Copy that icudt54.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll
240 and check that in. 255 and check that in.
241 256
242 10. Apply the following patches for regex 257 15. Apply a timezone detection API fix
243 - patches/regex.patch (a combined patch of 3 revisions below) 258 - patches/tzdetect.patch
244 - upstream bugs (fixed in the upstream 55 RC) 259 - upstream bugs
245 http://bugs.icu-project.org/trac/ticket/11370 (r36723:36724) 260 http://bugs.icu-project.org/trac/ticket/11623
246 http://bugs.icu-project.org/trac/ticket/11369 (r36726:36727)
247 http://bugs.icu-project.org/trac/ticket/11371 (r36800:36801)
248
249 11. Fix bugs in locid (getBaseName / thread safety).
250 - patches/locid.patch
251 - upstream bugs (fixed in the upstream 55 RC)
252 http://bugs.icu-project.org/trac/ticket/11421
253 http://bugs.icu-project.org/trac/ticket/11547
254
255 12. Fix bugs in BiDi
256 - patches/bidi.patch
257 - upstream bugs (fixed in the upstream 55 RC)
258 http://bugs.icu-project.org/trac/ticket/11177
259 http://bugs.icu-project.org/trac/ticket/11451
260
261 13. Fix a data race in cmemory
262 - patches/cmemory.patch
263 - upstream bug (fixed in the upstream 55 RC)
264 http://www.icu-project.org/trac/ticket/11538
265
266 14. Fix a bug found by 'stack' (static analysis tool)
267 - patches/uloc.patch
268 - upstream bug
269 http://www.icu-project.org/trac/ticket/11602
270
271 15. Add a timezone detection API
272 - patches/tzdetect.patch (applied in the upstream 55)
273 - patches/tzdetect2.patch
274 - upstream bugs
275 http://bugs.icu-project.org/trac/ticket/11358
276 http://bugs.icu-project.org/trac/ticket/11623
277
278 16. Properly handle a converter name starting with 'x-'.
279 - patches/ucnv_name.patch
280 - upstream bug
281 http://bugs.icu-project.org/trac/ticket/11696
282
283 17. Cherry-pick an upstream patch to add a separate field for ref-counting in
284 the converter data.
285 - patches/ucnv_refcount.patch
286 - upstream change:
287 http://bugs.icu-project.org/trac/ticket/11601
288
289 18. Apply patches/infinite-recursion.patch , corresponds to upstream r36672
290
291 19. Fix a data race in umutex
292 - patches/mutex.patch
293 - upstream bug (fixed in ToT and will be included in 56)
294 http://bugs.icu-project.org/trac/ticket/11599
295
296 20. Cherry-pick an upstream patch for a data loading bug.
297 - patches/dataload.patch
298 - upstream change (fixed in ToT and will be included in 56)
299 http://bugs.icu-project.org/trac/changeset/37670
300
301 21. Fix -Woverloaded-virtual warnings
302 - patches/woverloaded-virtual.patch
303
304 22. Fix -Wmicrosoft-unqulified-friend warning
305 - patches/stringthreadtest.patch
306 261
307 23. Fix 'bad cast' found in Transliterator with a cfi build 262 23. Fix 'bad cast' found in Transliterator with a cfi build
308 - patches/xlit_badcast.patch ; speculative 263 - patches/xlit_badcast.patch
309 - upstream bug (yet to be resolved) 264 - upstream bug (yet to be resolved)
310 http://bugs.icu-project.org/trac/ticket/11937 265 http://bugs.icu-project.org/trac/ticket/11937
OLDNEW
« no previous file with comments | « no previous file | patches/bidi.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698