Chromium Code Reviews
DescriptionMake Maximized Mode Not Suck, part 1 (checkpoint).
Pixel perfection (I think) on Normal and App windows, maximized and restored, on Windows XP Luna with default fonts and border widths. Among other things, fixes window control placement, tabstrip height, window icon/title placement, and client edge drawing (especially at the tops/bottoms of windows).
Known to still be broken: Popup windows
Untested: Vista non-Aero, Classic, non-default fonts/borders, non-main windows (Options, Task Manager, etc.)
This change is pretty hacky in some places; once I get the behavior nailed perfectly I'll need to go back and try and cut down on the number of constants and use better logic instead. I do at least try to remove some of the current hacks or else document them.
Eventually I'll need Ben's and Glen's eyeballs for things, as I've had to make judgment calls about the correct behaviors; some of these I copied our 1.0 behavior, and some I've tried to ape a native app more closely. Especially tricky are the positioning of window icons/titles, since our titlebar isn't quite like a native one.
BUG=5054
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7391
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
|||||||||||||||||||