Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 16219: Make Maximized Mode Not Suck, part 1 (checkpoint).... (Closed)

Created:
12 years ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make Maximized Mode Not Suck, part 1 (checkpoint). Pixel perfection (I think) on Normal and App windows, maximized and restored, on Windows XP Luna with default fonts and border widths. Among other things, fixes window control placement, tabstrip height, window icon/title placement, and client edge drawing (especially at the tops/bottoms of windows). Known to still be broken: Popup windows Untested: Vista non-Aero, Classic, non-default fonts/borders, non-main windows (Options, Task Manager, etc.) This change is pretty hacky in some places; once I get the behavior nailed perfectly I'll need to go back and try and cut down on the number of constants and use better logic instead. I do at least try to remove some of the current hacks or else document them. Eventually I'll need Ben's and Glen's eyeballs for things, as I've had to make judgment calls about the correct behaviors; some of these I copied our 1.0 behavior, and some I've tried to ape a native app more closely. Especially tricky are the positioning of window icons/titles, since our titlebar isn't quite like a native one. BUG=5054 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -164 lines) Patch
M chrome/browser/views/frame/opaque_non_client_view.cc View 13 chunks +176 lines, -164 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
12 years ago (2008-12-22 22:48:59 UTC) #1
sky
12 years ago (2008-12-22 23:05:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698