ICU 56 update step 1

source/io/ufile.c

 /*
 ******************************************************************************
 *
-*   Copyright (C) 1998-2014, International Business Machines
+*   Copyright (C) 1998-2015, International Business Machines
 *   Corporation and others.  All Rights Reserved.
 *
 ******************************************************************************
 *
 * File ufile.c
 *
 * Modification History:
 *
 *   Date        Name        Description
 *   11/19/98    stephen     Creation.
@@ skipping 41 matching lines @@
         return 0;
     }
     result = (UFILE*) uprv_malloc(sizeof(UFILE));
     if(result == NULL) {
         return 0;
     }
 
     uprv_memset(result, 0, sizeof(UFILE));
     result->fFileno = fileno(f);
 
-#if U_PLATFORM_USES_ONLY_WIN32_API
+#if U_PLATFORM_USES_ONLY_WIN32_API && _MSC_VER < 1900
+    /*
+     * Below is a very old workaround (ICU ticket:231).
+     *
+     * Previously, 'FILE*' from inside and outside ICU's DLL
+     * were different, because they pointed into local copies
+     * of the io block. At least by VS 2015 the implementation
+     * is something like:
+     *    stdio = _acrt_iob_func(0)
+     * .. which is a function call, so should return the same pointer
+     * regardless of call site.
+     * As of _MSC_VER 1900 this patch is retired, at 16 years old.
+     */
     if (0 <= result->fFileno && result->fFileno <= 2) {
         /* stdin, stdout and stderr need to be special cased for Windows 98 */
 #if _MSC_VER >= 1400
         result->fFile = &__iob_func()[_fileno(f)];
 #else
         result->fFile = &_iob[_fileno(f)];
 #endif
     }
     else
 #endif
@@ skipping 262 matching lines @@
     return file->fConverter;
 }
 #if !UCONFIG_NO_FORMATTING
 U_CAPI const UNumberFormat* U_EXPORT2 u_fgetNumberFormat(UFILE *file)
 {
     return u_locbund_getNumberFormat(&file->str.fBundle, UNUM_DECIMAL);
 }
 #endif
 
 #endif