Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 162183002: Don't attempt to unload the same extension twice if multiple ExtensionHost instances existed for th… (Closed)

Created:
6 years, 10 months ago by Marijn Kruisselbrink
Modified:
6 years, 10 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Don't attempt to unload the same extension twice if multiple ExtensionHost instances existed for the extension. This makes sure ExtensionService doesn't schedule a second TrackTerminatedExtension call if one call is already in progress. BUG=327735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251141

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Marijn Kruisselbrink
Maybe fixing this crash was straightforward after all...
6 years, 10 months ago (2014-02-12 23:52:07 UTC) #1
miket_OOO
On 2014/02/12 23:52:07, Marijn Kruisselbrink wrote: > Maybe fixing this crash was straightforward after all... ...
6 years, 10 months ago (2014-02-13 17:47:02 UTC) #2
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 10 months ago (2014-02-13 17:50:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/162183002/150001
6 years, 10 months ago (2014-02-13 17:51:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/162183002/150001
6 years, 10 months ago (2014-02-13 19:54:00 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 21:57:43 UTC) #6
Message was sent while issue was closed.
Change committed as 251141

Powered by Google App Engine
This is Rietveld 408576698