Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1621673002: [interpreter] Add ReThrow bytecode for try-finally support. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_int-6
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add ReThrow bytecode for try-finally support. This adds an explicit ReThrow bytecode to be used in the modelling of try-finally statements. An exception that is being re-thrown should not trigger message object creation or location computation and hence cannot use the existing Throw bytecode. R=rmcilroy@chromium.org TEST=cctest/test-interpreter/InterpreterTryFinally BUG=v8:4674 LOG=n Committed: https://crrev.com/475d178f2e10c70f20dd2f4f397073f3a70298a0 Cr-Commit-Position: refs/heads/master@{#33472}

Patch Set 1 #

Patch Set 2 : Adapt unit tests. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-22 11:50:16 UTC) #1
rmcilroy
You will need to add a call to builder()->ReThrow() in BytecodeArrayBuilderTest::AllBytecodesGenerated too, otherwise it will ...
4 years, 11 months ago (2016-01-22 12:21:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621673002/40001
4 years, 11 months ago (2016-01-22 16:18:37 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-22 16:25:52 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 16:26:23 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/475d178f2e10c70f20dd2f4f397073f3a70298a0
Cr-Commit-Position: refs/heads/master@{#33472}

Powered by Google App Engine
This is Rietveld 408576698