Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1621603005: Add a test of summary resynthesis that uses strong mode. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test of summary resynthesis that uses strong mode. This will be expanded once we start storing inferred types in summaries. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/afbac7a887e42a63543c693746f5df4ed387f515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -11 lines) Patch
A + pkg/analyzer/test/src/summary/resynthesize_strong_test.dart View 1 chunk +4 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 12 chunks +66 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-22 18:06:56 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-22 18:08:04 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-22 18:19:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afbac7a887e42a63543c693746f5df4ed387f515 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698