split webkit/glue/webpreferences to common and renderer

webkit/common/webpreferences.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A struct for managing webkit's settings.
 //
 // Adding new values to this class probably involves updating
 // WebKit::WebSettings, content/common/view_messages.h, browser/tab_contents/
 // render_view_host_delegate_helper.cc, and browser/profiles/profile.cc.
 
@@ skipping 29 matching lines @@
   EDITING_BEHAVIOR_UNIX,
   EDITING_BEHAVIOR_ANDROID
 };
 
 
 // The ISO 15924 script code for undetermined script aka Common. It's the
 // default used on WebKit's side to get/set a font setting when no script is
 // specified.
 WEBKIT_GLUE_EXPORT extern const char kCommonScript[];
 
 WEBKIT_GLUE_EXPORT void ApplyWebPreferences(const WebPreferences& prefs,

[jamesr, 2013/05/30 20:24:23]

could we just move this function declaration to a header that lives in
webkit/renderer/ to avoid the sketchy? with this arrangement, code that's in the
browser process can see webkit/common/webpreferences.h and see the declaration
of this function, but it can't see the definition of the symbol so it'll be a
link error if it tries to use it. that seems a little subtle. the function
itself is just a free function

[scottmg, 2013/05/30 21:03:51]

Done.

                                             WebKit::WebView* web_view);
 
 }  // namespace webkit_glue
 
 struct WEBKIT_GLUE_EXPORT WebPreferences {
   webkit_glue::ScriptFontFamilyMap standard_font_family_map;
   webkit_glue::ScriptFontFamilyMap fixed_font_family_map;
   webkit_glue::ScriptFontFamilyMap serif_font_family_map;
   webkit_glue::ScriptFontFamilyMap sans_serif_font_family_map;
   webkit_glue::ScriptFontFamilyMap cursive_font_family_map;
@@ skipping 114 matching lines @@
 #endif
 
   // We try to keep the default values the same as the default values in
   // chrome, except for the cases where it would require lots of extra work for
   // the embedder to use the same default value.
   WebPreferences();
   ~WebPreferences();
 };
 
 #endif  // WEBKIT_GLUE_WEBPREFERENCES_H__