Issue 16216: Adds support for pauseAnimationAtTimeOnElementWithId and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16216: Adds support for pauseAnimationAtTimeOnElementWithId and... (Closed)

Created:
12 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds support for pauseAnimationAtTimeOnElementWithId and pauseTransitionAtTimeOnElementWithId to layout test controller so that we can pass a couple of additional tests. BUG=5801 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7379

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -5 lines)			Patch
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/animations/README	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/animations/animation-drt-api-multiple-keyframes-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/animations/animation-drt-api-multiple-keyframes-expected.png	View	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/animations/animation-drt-api-multiple-keyframes-expected.txt	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	webkit/glue/dom_operations.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	webkit/glue/dom_operations.cc	View	2 chunks	+47 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	3 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

12 years ago (2008-12-22 21:51:32 UTC) #2

LGTM

It occurs to me that we might want to have a dom_operations_testing.{h,cc} set
of files so that we can either avoid linking this code in chrome, or so that we
can help ensure that the linker will strip it away.

Expand Messages | Collapse Messages