Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1621503003: Remove 'WebPlugin::CheckIfRunInsecureContent'. (Closed)

Created:
4 years, 11 months ago by Mike West
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'WebPlugin::CheckIfRunInsecureContent'. We don't need this anymore, as non-NPAPI plugins run through the normal loading infrastructure, and are correctly checked for mixed content violations. BUG=493212 Committed: https://crrev.com/98bda6fbd2ce71a9721f66426d95f3d1340319ce Cr-Commit-Position: refs/heads/master@{#370963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M content/child/npapi/webplugin.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/plugin_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/plugin/webplugin_proxy.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
PTAL.
4 years, 11 months ago (2016-01-22 11:02:13 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-22 14:36:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621503003/1
4 years, 11 months ago (2016-01-22 14:44:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 14:49:32 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 14:51:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98bda6fbd2ce71a9721f66426d95f3d1340319ce
Cr-Commit-Position: refs/heads/master@{#370963}

Powered by Google App Engine
This is Rietveld 408576698